Skip to content

Commit 354ad46

Browse files
authored
chore: drop leftover JVM Parquet helpers and the native_datafusion scan name (#4385)
1 parent 184a883 commit 354ad46

10 files changed

Lines changed: 17 additions & 767 deletions

File tree

.claude/skills/bug-triage/SKILL.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ For each issue, review the title and body and determine:
6565
2. **Area labels** (zero or more): from the area table in the guide
6666
(`area:writer`, `area:shuffle`, `area:aggregation`, `area:scan`,
6767
`area:expressions`, `area:ffi`, `area:ci`) plus the pre-existing area
68-
indicators (`native_datafusion`, `native_iceberg_compat`, `spark 4`,
69-
`spark sql tests`).
68+
indicators (`spark 4`, `spark sql tests`).
7069
3. **Escalation note**: if the issue matches an escalation trigger from the
7170
guide (e.g., a `priority:high` crash that may also produce wrong results),
7271
note it in the summary.

native/core/src/parquet/parquet_exec.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ use datafusion_datasource::TableSchema;
3838
use std::collections::HashMap;
3939
use std::sync::Arc;
4040

41-
/// Initializes a DataSourceExec plan with a ParquetSource. This may be used by either the
42-
/// `native_datafusion` scan or the `native_iceberg_compat` scan.
41+
/// Initializes a DataSourceExec plan with a ParquetSource for Comet's native Parquet scan.
4342
///
4443
/// `required_schema`: Schema to be projected by the scan.
4544
///

spark/src/main/java/org/apache/parquet/filter2/predicate/SparkFilterApi.java

Lines changed: 0 additions & 54 deletions
This file was deleted.

spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,14 +182,14 @@ case class CometScanRule(session: SparkSession)
182182
return scanExec
183183
}
184184

185-
nativeDataFusionScan(plan, session, scanExec, r, hadoopConf).getOrElse(scanExec)
185+
nativeScan(plan, session, scanExec, r, hadoopConf).getOrElse(scanExec)
186186

187187
case _ =>
188188
withInfo(scanExec, s"Unsupported relation ${scanExec.relation}")
189189
}
190190
}
191191

192-
private def nativeDataFusionScan(
192+
private def nativeScan(
193193
plan: SparkPlan,
194194
session: SparkSession,
195195
scanExec: FileSourceScanExec,

spark/src/main/scala/org/apache/comet/serde/operator/CometNativeScan.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ import org.apache.comet.serde.OperatorOuterClass.Operator
4141
import org.apache.comet.serde.QueryPlanSerde.{exprToProto, serializeDataType}
4242

4343
/**
44-
* Validation and serde logic for `native_datafusion` scans.
44+
* Validation and serde logic for Comet's native Parquet scan.
4545
*/
4646
object CometNativeScan extends CometOperatorSerde[CometScanExec] with Logging {
4747

0 commit comments

Comments
 (0)