refactor: rename spark-errors crate to common

Author: andygrove

native/Cargo.lock

@@ -16,8 +16,8 @@
 # under the License.
 
 [workspace]
-default-members = ["core", "spark-expr", "spark-errors", "proto", "jni-bridge"]
-members = ["core", "spark-expr", "spark-errors", "proto", "jni-bridge", "hdfs", "fs-hdfs"]
+default-members = ["core", "spark-expr", "common", "proto", "jni-bridge"]
+members = ["core", "spark-expr", "common", "proto", "jni-bridge", "hdfs", "fs-hdfs"]
 resolver = "2"
 
 [workspace.package]
@@ -43,7 +43,7 @@ datafusion-datasource = { version = "52.2.0" }
 datafusion-physical-expr-adapter = { version = "52.2.0" }
 datafusion-spark = { version = "52.2.0" }
 datafusion-comet-spark-expr = { path = "spark-expr" }
-datafusion-comet-spark-errors = { path = "spark-errors" }
+datafusion-comet-common = { path = "common" }
 datafusion-comet-jni-bridge = { path = "jni-bridge" }
 datafusion-comet-proto = { path = "proto" }
 chrono = { version = "0.4", default-features = false, features = ["clock"] }

native/Cargo.toml

@@ -16,8 +16,8 @@
 # under the License.
 
 [package]
-name = "datafusion-comet-spark-errors"
-description = "Apache DataFusion Comet: Spark error types"
+name = "datafusion-comet-common"
+description = "Apache DataFusion Comet: common types shared across crates"
 version = { workspace = true }
 homepage = { workspace = true }
 repository = { workspace = true }
@@ -36,5 +36,5 @@ serde_json = "1.0"
 thiserror = { workspace = true }
 
 [lib]
-name = "datafusion_comet_spark_errors"
+name = "datafusion_comet_common"
 path = "src/lib.rs"

native/spark-errors/Cargo.toml native/common/Cargo.tomlnative/spark-errors/Cargo.toml renamed to native/common/Cargo.toml

@@ -39,7 +39,7 @@ lazy_static = "1.4.0"
 once_cell = "1.18.0"
 paste = "1.0.14"
 prost = "0.14.3"
-datafusion-comet-spark-errors = { workspace = true }
+datafusion-comet-common = { workspace = true }
 
 [dev-dependencies]
 jni = { version = "0.21", features = ["invocation"] }

native/spark-errors/src/error.rs native/common/src/error.rsnative/spark-errors/src/error.rs renamed to native/common/src/error.rs

@@ -19,7 +19,7 @@
 
 use arrow::error::ArrowError;
 use datafusion::common::DataFusionError;
-use datafusion_comet_spark_errors::{SparkError, SparkErrorWithContext};
+use datafusion_comet_common::{SparkError, SparkErrorWithContext};
 use jni::errors::{Exception, ToException};
 use regex::Regex;
 

native/spark-errors/src/lib.rs native/common/src/lib.rsnative/spark-errors/src/lib.rs renamed to native/common/src/lib.rs

@@ -34,7 +34,7 @@ chrono-tz = { workspace = true }
 num = { workspace = true }
 regex = { workspace = true }
 serde_json = "1.0"
-datafusion-comet-spark-errors = { workspace = true }
+datafusion-comet-common = { workspace = true }
 futures = { workspace = true }
 twox-hash = "2.1.2"
 rand = { workspace = true }

native/spark-errors/src/query_context.rs native/common/src/query_context.rsnative/spark-errors/src/query_context.rs renamed to native/common/src/query_context.rs

@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-// Re-export all error types from the spark-errors crate
-pub use datafusion_comet_spark_errors::{
+// Re-export all error types from the common crate
+pub use datafusion_comet_common::{
     decimal_overflow_error, SparkError, SparkErrorWithContext, SparkResult,
 };