Skip to content

Commit 37d10e3

Browse files
committed
Revert "fix: accept native DataFusion error message for duplicate fields in 3.5.8 diff"
This reverts commit 03328cd.
1 parent 03328cd commit 37d10e3

1 file changed

Lines changed: 5 additions & 22 deletions

File tree

dev/diffs/3.5.8.diff

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1999,7 +1999,7 @@ index 07e2849ce6f..3e73645b638 100644
19991999
ParquetOutputFormat.WRITER_VERSION -> ParquetProperties.WriterVersion.PARQUET_2_0.toString
20002000
)
20012001
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
2002-
index 8e88049f51e..6150a556f9b 100644
2002+
index 8e88049f51e..e21a5797996 100644
20032003
--- a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
20042004
+++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
20052005
@@ -1095,7 +1095,11 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
@@ -2088,24 +2088,7 @@ index 8e88049f51e..6150a556f9b 100644
20882088
val schema = StructType(Seq(
20892089
StructField("a", IntegerType, nullable = false)
20902090
))
2091-
@@ -1952,8 +1968,14 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
2092-
val e = intercept[SparkException] {
2093-
sql(s"select a from $tableName where b > 0").collect()
2094-
}
2095-
- assert(e.getCause.isInstanceOf[RuntimeException] && e.getCause.getMessage.contains(
2096-
- """Found duplicate field(s) "B": [B, b] in case-insensitive mode"""))
2097-
+ assert(e.getCause.isInstanceOf[RuntimeException])
2098-
+ val msg = e.getCause.getMessage
2099-
+ // native_datafusion produces a different error message for duplicate fields
2100-
+ assert(
2101-
+ msg.contains(
2102-
+ """Found duplicate field(s) "B": [B, b] in case-insensitive mode""") ||
2103-
+ msg.contains("Unable to get field named"),
2104-
+ s"Unexpected error message: $msg")
2105-
}
2106-
2107-
withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
2108-
@@ -1984,7 +2006,8 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
2091+
@@ -1984,7 +2000,8 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
21092092
}
21102093
}
21112094

@@ -2115,7 +2098,7 @@ index 8e88049f51e..6150a556f9b 100644
21152098
// block 1:
21162099
// null count min max
21172100
// page-0 0 0 99
2118-
@@ -2044,7 +2067,8 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
2101+
@@ -2044,7 +2061,8 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
21192102
}
21202103
}
21212104

@@ -2125,7 +2108,7 @@ index 8e88049f51e..6150a556f9b 100644
21252108
withTempPath { dir =>
21262109
val path = dir.getCanonicalPath
21272110
spark.range(100).selectExpr("id * 2 AS id")
2128-
@@ -2276,7 +2300,11 @@ class ParquetV1FilterSuite extends ParquetFilterSuite {
2111+
@@ -2276,7 +2294,11 @@ class ParquetV1FilterSuite extends ParquetFilterSuite {
21292112
assert(pushedParquetFilters.exists(_.getClass === filterClass),
21302113
s"${pushedParquetFilters.map(_.getClass).toList} did not contain ${filterClass}.")
21312114

@@ -2138,7 +2121,7 @@ index 8e88049f51e..6150a556f9b 100644
21382121
} else {
21392122
assert(selectedFilters.isEmpty, "There is filter pushed down")
21402123
}
2141-
@@ -2336,7 +2364,11 @@ class ParquetV2FilterSuite extends ParquetFilterSuite {
2124+
@@ -2336,7 +2358,11 @@ class ParquetV2FilterSuite extends ParquetFilterSuite {
21422125
assert(pushedParquetFilters.exists(_.getClass === filterClass),
21432126
s"${pushedParquetFilters.map(_.getClass).toList} did not contain ${filterClass}.")
21442127

0 commit comments

Comments
 (0)