Skip to content

Commit 4be8144

Browse files
committed
Remove code related to #4239.
1 parent caffed9 commit 4be8144

16 files changed

Lines changed: 24 additions & 909 deletions

File tree

.github/workflows/pr_build_linux.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,6 @@ jobs:
389389
org.apache.comet.expressions.conditional.CometCaseWhenSuite
390390
org.apache.comet.CometCodegenDispatchSmokeSuite
391391
org.apache.comet.CometCodegenSourceSuite
392-
org.apache.comet.CometRegExpJvmSuite
393392
- name: "sql"
394393
value: |
395394
org.apache.spark.sql.CometToPrettyStringSuite

.github/workflows/pr_build_macos.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,6 @@ jobs:
236236
org.apache.comet.expressions.conditional.CometCaseWhenSuite
237237
org.apache.comet.CometCodegenDispatchSmokeSuite
238238
org.apache.comet.CometCodegenSourceSuite
239-
org.apache.comet.CometRegExpJvmSuite
240239
- name: "sql"
241240
value: |
242241
org.apache.spark.sql.CometToPrettyStringSuite
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<!---
2+
Licensed to the Apache Software Foundation (ASF) under one
3+
or more contributor license agreements. See the NOTICE file
4+
distributed with this work for additional information
5+
regarding copyright ownership. The ASF licenses this file
6+
to you under the Apache License, Version 2.0 (the
7+
"License"); you may not use this file except in compliance
8+
with the License. You may obtain a copy of the License at
9+
10+
http://www.apache.org/licenses/LICENSE-2.0
11+
12+
Unless required by applicable law or agreed to in writing,
13+
software distributed under the License is distributed on an
14+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
KIND, either express or implied. See the License for the
16+
specific language governing permissions and limitations
17+
under the License.
18+
-->
19+
20+
# Regular Expressions
21+
22+
Comet uses the Rust regexp crate for evaluating regular expressions, and this has different behavior from Java's
23+
regular expression engine. Comet will fall back to Spark for patterns that are known to produce different results, but
24+
this can be overridden by setting `spark.comet.expression.regexp.allowIncompatible=true`.

spark/src/test/resources/sql-tests/expressions/string/regexp_extract.sql

Lines changed: 0 additions & 56 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/regexp_extract_all.sql

Lines changed: 0 additions & 52 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/regexp_instr.sql

Lines changed: 0 additions & 48 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/regexp_replace_java.sql

Lines changed: 0 additions & 50 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/regexp_replace_rust.sql

Lines changed: 0 additions & 30 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/regexp_replace_rust_enabled.sql

Lines changed: 0 additions & 36 deletions
This file was deleted.

spark/src/test/resources/sql-tests/expressions/string/rlike_java.sql

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)