Skip to content

Commit 4bf5435

Browse files
committed
chore: remove dead Rust column-reader code
The JVM-side Parquet column readers were deleted in the previous commit; the Rust JNI methods and supporting modules they called are now dead. - parquet/mod.rs: drop JNI methods initColumnReader, setDictionaryPage, setPageV1, setPageV2, resetBatch, readBatch, skipBatch, currentBatch, closeColumnReader, plus the Context/get_reader helpers. - Delete parquet/read/ (column, levels, values, mod), mutable_vector.rs, data_type.rs, and the util sub-modules bit_packing, buffer, memory, test_common that only existed for the column readers. - Trim parquet/util/jni.rs to deserialize_schema (the only helper used by the surviving Arrow-native scan path). - Delete native/core/src/common/ entirely; bit.rs and buffer.rs were only consumed by the deleted parquet column-reader chain. - Drop the parquet_read, bit_util, and parquet_decode benches that exercised the removed code; deregister them from Cargo.toml.
1 parent d03d99a commit 4bf5435

23 files changed

Lines changed: 6 additions & 10398 deletions

native/core/Cargo.toml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,6 @@ name = "comet"
109109
# "rlib" is for benchmarking with criterion.
110110
crate-type = ["cdylib", "rlib"]
111111

112-
[[bench]]
113-
name = "parquet_read"
114-
harness = false
115-
116-
[[bench]]
117-
name = "bit_util"
118-
harness = false
119-
120-
[[bench]]
121-
name = "parquet_decode"
122-
harness = false
123-
124112
[[bench]]
125113
name = "array_element_append"
126114
harness = false

native/core/benches/bit_util.rs

Lines changed: 0 additions & 216 deletions
This file was deleted.

native/core/benches/parquet_decode.rs

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)