Commit 5f3238c
committed
test: regenerate tpcds-v1.4/{q24a,q24b} and tpcds-v2.7.0/q24 goldens
`CometCaseConversionBase` no longer gates compat with the bespoke
`spark.comet.caseConversion.enabled` conf inside `convert()`. The
fallback now flows through the standard dispatcher path, so the
`BroadcastHashJoin` COMET tag on `upper(ca_country)` switches from
"Comet is not compatible with Spark for case conversion in
locale-specific cases. Set spark.comet.caseConversion.enabled=true
to enable it anyway."
to the dispatcher's per-expression Incompatible message, including
the `spark.comet.expression.Upper.allowIncompatible=true` opt-in and
the compat-guide link. The plan shape is unchanged; only the two
annotation lines in each affected golden differ.1 parent e6694b1 commit 5f3238c
3 files changed
Lines changed: 6 additions & 6 deletions
File tree
- spark/src/test/resources/tpcds-plan-stability
- approved-plans-v1_4
- q24a
- q24b
- approved-plans-v2_7/q24
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments