int_to_binary

Author: coderfender

spark/src/main/scala/org/apache/comet/expressions/CometCast.scala

@@ -276,13 +276,8 @@ object CometCast extends CometExpressionSerde[Cast] with CometExprShim {
         Compatible()
       case DataTypes.FloatType | DataTypes.DoubleType | _: DecimalType =>
         Compatible()
-      case DataTypes.BinaryType =>
-        if (evalMode == CometEvalMode.LEGACY) {
-          Compatible()
-        } else {
-          Unsupported(
-            Some(s"Spark does not support byte to binary conversion in ${evalMode} eval mode"))
-        }
+      case DataTypes.BinaryType if (evalMode == CometEvalMode.LEGACY) =>
+        Compatible()
       case _ =>
         unsupported(DataTypes.ByteType, toType)
     }
@@ -295,13 +290,8 @@ object CometCast extends CometExpressionSerde[Cast] with CometExprShim {
         Compatible()
       case DataTypes.FloatType | DataTypes.DoubleType | _: DecimalType =>
         Compatible()
-      case DataTypes.BinaryType =>
-        if (evalMode == CometEvalMode.LEGACY) {
-          Compatible()
-        } else {
-          Unsupported(
-            Some(s"Spark does not support short to binary conversion in ${evalMode} eval mode"))
-        }
+      case DataTypes.BinaryType if (evalMode == CometEvalMode.LEGACY) =>
+        Compatible()
       case _ =>
         unsupported(DataTypes.ShortType, toType)
     }
@@ -316,13 +306,7 @@ object CometCast extends CometExpressionSerde[Cast] with CometExprShim {
         Compatible()
       case _: DecimalType =>
         Compatible()
-      case DataTypes.BinaryType =>
-        if (evalMode == CometEvalMode.LEGACY) {
-          Compatible()
-        } else {
-          Unsupported(
-            Some(s"Spark does not support int to binary conversion in ${evalMode} eval mode"))
-        }
+      case DataTypes.BinaryType if (evalMode == CometEvalMode.LEGACY) => Compatible()
       case _ =>
         unsupported(DataTypes.IntegerType, toType)
     }
@@ -337,13 +321,7 @@ object CometCast extends CometExpressionSerde[Cast] with CometExprShim {
         Compatible()
       case _: DecimalType =>
         Compatible()
-      case DataTypes.BinaryType =>
-        if (evalMode == CometEvalMode.LEGACY) {
-          Compatible()
-        } else {
-          Unsupported(
-            Some(s"Spark does not support long to binary conversion in ${evalMode} eval mode"))
-        }
+      case DataTypes.BinaryType if (evalMode == CometEvalMode.LEGACY) => Compatible()
       case _ =>
         unsupported(DataTypes.LongType, toType)
     }

spark/src/test/scala/org/apache/comet/CometCastSuite.scala

@@ -211,7 +211,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     castTest(
       generateBytes(),
       DataTypes.BinaryType,
-      hasIncompatibleType = usingParquetExecWithIncompatTypes, testAnsi = false, testTry = false)
+      hasIncompatibleType = usingParquetExecWithIncompatTypes,
+      testAnsi = false,
+      testTry = false)
   }
 
   ignore("cast ByteType to TimestampType") {
@@ -286,7 +288,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     castTest(
       generateShorts(),
       DataTypes.BinaryType,
-      hasIncompatibleType = usingParquetExecWithIncompatTypes, testAnsi = false, testTry = false)
+      hasIncompatibleType = usingParquetExecWithIncompatTypes,
+      testAnsi = false,
+      testTry = false)
   }
 
   ignore("cast ShortType to TimestampType") {
@@ -396,7 +400,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
 
   test("cast LongType to BinaryType") {
     //    Spark does not support ANSI or Try mode
-    castTest(generateLongs(), DataTypes.BinaryType , testAnsi = false, testTry = false)
+    castTest(generateLongs(), DataTypes.BinaryType, testAnsi = false, testTry = false)
   }
 
   ignore("cast LongType to TimestampType") {
@@ -1361,7 +1365,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
           checkSparkAnswerAndOperator(df)
         }
 
-        if (testTry){
+        if (testTry) {
           // try_cast() should always return null for invalid inputs
           val df2 =
             data.select(col("a"), col("a").try_cast(toType)).orderBy(col("a"))
@@ -1427,9 +1431,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
           }
 
           // try_cast() should always return null for invalid inputs
-          if (testTry){
+          if (testTry) {
             val df2 =
-              data.select(col("a"), col("a").cast(toType)).orderBy(col("a"))
+              data.select(col("a"), col("a").try_cast(toType)).orderBy(col("a"))
             if (hasIncompatibleType) {
               checkSparkAnswer(df2)
             } else {