Add temporal casts

Author: andygrove

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastBooleanBenchmark.scala

@@ -71,7 +71,7 @@ object CometCastBooleanBenchmark extends CometBenchmarkBase {
     s"SELECT $castFunc($colName AS BOOLEAN) FROM parquetV1Table")
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate boolean data for boolean-to-other casts
     runBenchmarkWithTable("Boolean to other types casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastNumericToNumericBenchmark.scala

@@ -92,7 +92,7 @@ object CometCastNumericToNumericBenchmark extends CometBenchmarkBase {
   }
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate input data once with all numeric types
     runBenchmarkWithTable("Numeric to Numeric casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastNumericToStringBenchmark.scala

@@ -54,7 +54,7 @@ object CometCastNumericToStringBenchmark extends CometBenchmarkBase {
     s"SELECT $castFunc($colName AS STRING) FROM parquetV1Table")
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate input data once with all numeric types
     runBenchmarkWithTable("Numeric to String casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastNumericToTemporalBenchmark.scala

@@ -52,7 +52,7 @@ object CometCastNumericToTemporalBenchmark extends CometBenchmarkBase {
     s"SELECT $castFunc(c_long AS TIMESTAMP) FROM parquetV1Table")
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate data once for INT to DATE conversions
     runBenchmarkWithTable("Int to Date casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastTemporalToNumericBenchmark.scala

@@ -56,7 +56,7 @@ object CometCastTemporalToNumericBenchmark extends CometBenchmarkBase {
     s"SELECT $castFunc(c_timestamp AS $targetType) FROM parquetV1Table")
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate DATE data once for all date-to-numeric benchmarks
     runBenchmarkWithTable("Date to Numeric casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastTemporalToStringBenchmark.scala

@@ -49,7 +49,7 @@ object CometCastTemporalToStringBenchmark extends CometBenchmarkBase {
     s"SELECT $castFunc(c_timestamp AS STRING) FROM parquetV1Table")
 
   override def runCometBenchmark(mainArgs: Array[String]): Unit = {
-    val values = getBenchmarkRows(1024 * 1024 * 5) // 5M rows default
+    val values = 1024 * 1024 * 5 // 5M rows
 
     // Generate temporal data once for date benchmarks
     runBenchmarkWithTable("Date to String casts", values) { v =>

spark/src/test/scala/org/apache/spark/sql/benchmark/CometCastTemporalToTemporalBenchmark.scala

@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.spark.sql.benchmark
+
+case class CastTemporalToTemporalConfig(
+    name: String,
+    query: String,
+    extraCometConfigs: Map[String, String] = Map.empty)
+
+/**
+ * Benchmark to measure performance of Comet cast between temporal types. To run this benchmark:
+ * {{{
+ *   SPARK_GENERATE_BENCHMARK_FILES=1 make benchmark-org.apache.spark.sql.benchmark.CometCastTemporalToTemporalBenchmark
+ * }}}
+ * Results will be written to
+ * "spark/benchmarks/CometCastTemporalToTemporalBenchmark-**results.txt".
+ */
+object CometCastTemporalToTemporalBenchmark extends CometBenchmarkBase {
+
+  private val castFunctions = Seq("CAST", "TRY_CAST")
+
+  // Date to Timestamp
+  private val dateToTimestampConfigs = for {
+    castFunc <- castFunctions
+  } yield CastTemporalToTemporalConfig(
+    s"$castFunc Date to Timestamp",
+    s"SELECT $castFunc(c_date AS TIMESTAMP) FROM parquetV1Table")
+
+  // Timestamp to Date
+  private val timestampToDateConfigs = for {
+    castFunc <- castFunctions
+  } yield CastTemporalToTemporalConfig(
+    s"$castFunc Timestamp to Date",
+    s"SELECT $castFunc(c_timestamp AS DATE) FROM parquetV1Table")
+
+  override def runCometBenchmark(mainArgs: Array[String]): Unit = {
+    val values = 1024 * 1024 * 5 // 5M rows
+
+    // Generate DATE data for Date -> Timestamp benchmarks
+    runBenchmarkWithTable("Date to Timestamp casts", values) { v =>
+      withTempPath { dir =>
+        withTempTable("parquetV1Table") {
+          prepareTable(
+            dir,
+            spark.sql(s"""
+              SELECT CASE
+                WHEN value % 100 = 0 THEN NULL
+                ELSE DATE_ADD('2020-01-01', CAST(value % 3650 AS INT))
+              END AS c_date
+              FROM $tbl
+            """))
+
+          dateToTimestampConfigs.foreach { config =>
+            runExpressionBenchmark(config.name, v, config.query, config.extraCometConfigs)
+          }
+        }
+      }
+    }
+
+    // Generate TIMESTAMP data for Timestamp -> Date benchmarks
+    runBenchmarkWithTable("Timestamp to Date casts", values) { v =>
+      withTempPath { dir =>
+        withTempTable("parquetV1Table") {
+          prepareTable(
+            dir,
+            spark.sql(s"""
+              SELECT CASE
+                WHEN value % 100 = 0 THEN NULL
+                ELSE TIMESTAMP_MICROS(1577836800000000 + value % 31536000000000)
+              END AS c_timestamp
+              FROM $tbl
+            """))
+
+          timestampToDateConfigs.foreach { config =>
+            runExpressionBenchmark(config.name, v, config.query, config.extraCometConfigs)
+          }
+        }
+      }
+    }
+  }
+}