Skip to content

Commit 6b4a47d

Browse files
andygroveclaude
andcommitted
fix: add missing @IcebergApi annotations
Add annotations to: - AbstractColumnReader.nativeHandle (protected field accessed by Iceberg subclasses) - AbstractCometSchemaImporter.close() (called by Iceberg) Also update documentation to include these APIs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 2a0e7d1 commit 6b4a47d

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

common/src/main/java/org/apache/arrow/c/AbstractCometSchemaImporter.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
package org.apache.arrow.c;
2121

22+
import org.apache.comet.IcebergApi;
23+
2224
import org.apache.arrow.memory.BufferAllocator;
2325
import org.apache.arrow.vector.FieldVector;
2426
import org.apache.arrow.vector.types.pojo.Field;
@@ -67,6 +69,7 @@ public FieldVector importVector(ArrowArray array, ArrowSchema schema) {
6769
return vector;
6870
}
6971

72+
@IcebergApi
7073
public void close() {
7174
provider.close();
7275
}

common/src/main/java/org/apache/comet/parquet/AbstractColumnReader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public abstract class AbstractColumnReader implements AutoCloseable {
6464
protected int batchSize;
6565

6666
/** A pointer to the native implementation of ColumnReader. */
67+
@IcebergApi
6768
protected long nativeHandle;
6869

6970
AbstractColumnReader(

docs/source/contributor-guide/iceberg_public_api.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,9 @@ public Map<String, String> getLogicalTypeParams()
131131
Base class for column readers.
132132

133133
```java
134+
// Protected field accessed by Iceberg subclasses
135+
protected long nativeHandle
136+
134137
// Methods used by Iceberg
135138
public void setBatchSize(int batchSize)
136139
public void close()
@@ -240,6 +243,17 @@ Imports and converts schemas between Arrow and Spark formats.
240243
// Constructor
241244
public CometSchemaImporter(RootAllocator allocator)
242245

246+
// Methods used by Iceberg (inherited from AbstractCometSchemaImporter)
247+
public void close()
248+
```
249+
250+
## Package: `org.apache.arrow.c`
251+
252+
### AbstractCometSchemaImporter
253+
254+
Base class for `CometSchemaImporter`.
255+
256+
```java
243257
// Methods used by Iceberg
244258
public void close()
245259
```

0 commit comments

Comments
 (0)