You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .claude/skills/review-comet-pr/SKILL.md
+6Lines changed: 6 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -52,6 +52,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
52
52
**For any PR that adds or modifies an expression, you must read the Spark source code to understand the canonical behavior.** This is the authoritative reference for what Comet must match.
53
53
54
54
1.**Clone or update the Spark repo:**
55
+
55
56
```bash
56
57
# Clone if not already present (use /tmp to avoid polluting the workspace)
57
58
if [ !-d /tmp/spark ];then
@@ -60,6 +61,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
60
61
```
61
62
62
63
2.**Find the expression implementation in Spark:**
64
+
63
65
```bash
64
66
# Search for the expression class (e.g., for "Conv", "Hex", "Substring")
65
67
find /tmp/spark/sql/catalyst/src/main/scala -name "*.scala"| xargs grep -l "case class <ExpressionName>"
@@ -73,6 +75,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
73
75
- ANSI mode branches (look for `SQLConf.get.ansiEnabled` or `failOnError`).
0 commit comments