Skip to content

Commit 744f161

Browse files
committed
prettier
1 parent 18589be commit 744f161

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

.claude/skills/review-comet-pr/SKILL.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
5252
**For any PR that adds or modifies an expression, you must read the Spark source code to understand the canonical behavior.** This is the authoritative reference for what Comet must match.
5353

5454
1. **Clone or update the Spark repo:**
55+
5556
```bash
5657
# Clone if not already present (use /tmp to avoid polluting the workspace)
5758
if [ ! -d /tmp/spark ]; then
@@ -60,6 +61,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
6061
```
6162

6263
2. **Find the expression implementation in Spark:**
64+
6365
```bash
6466
# Search for the expression class (e.g., for "Conv", "Hex", "Substring")
6567
find /tmp/spark/sql/catalyst/src/main/scala -name "*.scala" | xargs grep -l "case class <ExpressionName>"
@@ -73,6 +75,7 @@ For expression PRs, check how similar expressions are implemented in the codebas
7375
- ANSI mode branches (look for `SQLConf.get.ansiEnabled` or `failOnError`).
7476

7577
4. **Read the Spark tests for the expression:**
78+
7679
```bash
7780
# Find test files
7881
find /tmp/spark/sql -name "*.scala" -path "*/test/*" | xargs grep -l "<ExpressionName>"
@@ -181,6 +184,7 @@ SELECT known_buggy_expr(v) FROM test_table
181184
```
182185

183186
**Running SQL file tests:**
187+
184188
```bash
185189
# All SQL file tests
186190
./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite" -Dtest=none
@@ -272,11 +276,13 @@ Present your review as guidance for the reviewer. Structure your output as:
272276
## Review Tone and Style
273277

274278
Write reviews that sound human and conversational. Avoid:
279+
275280
- Robotic or formulaic language
276281
- Em dashes. Use separate sentences instead.
277282
- Semicolons. Use separate sentences instead.
278283

279284
Instead:
285+
280286
- Write in flowing paragraphs using simple grammar
281287
- Keep sentences short and separate rather than joining them with punctuation
282288
- Be kind and constructive, even when raising concerns

0 commit comments

Comments
 (0)