Skip to content

Commit 78c2e23

Browse files
author
Kazantsev Maksim
committed
Fix PR issues
1 parent 37b9736 commit 78c2e23

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

native/spark-expr/src/csv_funcs/csv_write_options.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ impl Display for CsvWriteOptions {
3232
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
3333
write!(
3434
f,
35-
"csv_write_options(quote={}, escape={}, null_value={}, quote_all={}, ignore_leading_white_space={}, ignore_trailing_white_space={})",
36-
self.quote, self.escape, self.null_value, self.quote_all, self.ignore_leading_white_space, self.ignore_trailing_white_space
35+
"csv_write_options(delimiter={}, quote={}, escape={}, null_value={}, quote_all={}, ignore_leading_white_space={}, ignore_trailing_white_space={})",
36+
self.delimiter, self.quote, self.escape, self.null_value, self.quote_all, self.ignore_leading_white_space, self.ignore_trailing_white_space
3737
)
3838
}
3939
}

spark/src/main/scala/org/apache/comet/serde/structs.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,8 @@ object CometStructsToCsv extends CometExpressionSerde[StructsToCsv] {
252252
s"The schema ${expr.inputSchema} is not supported because " +
253253
s"it includes a incompatible data types: $incompatibleDataTypes"))
254254
}
255-
Compatible()
255+
// https://github.com/apache/datafusion-comet/issues/3232
256+
Incompatible()
256257
}
257258

258259
override def convert(

0 commit comments

Comments
 (0)