Skip to content

Commit 7979fca

Browse files
committed
fix: enable Corr allowIncompatible for covariance & correlation test
1 parent 3e10523 commit 7979fca

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
-- specific language governing permissions and limitations
1616
-- under the License.
1717

18+
-- Config: spark.comet.expression.Corr.allowIncompatible=true
1819
-- ConfigMatrix: parquet.enable.dictionary=false,true
1920

2021
statement

spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import scala.util.Random
2424
import org.apache.hadoop.fs.Path
2525
import org.apache.spark.sql.{CometTestBase, DataFrame, Row}
2626
import org.apache.spark.sql.catalyst.expressions.Cast
27+
import org.apache.spark.sql.catalyst.expressions.aggregate.Corr
2728
import org.apache.spark.sql.catalyst.optimizer.EliminateSorts
2829
import org.apache.spark.sql.comet.CometHashAggregateExec
2930
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper
@@ -1319,7 +1320,9 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
13191320
}
13201321

13211322
test("covariance & correlation") {
1322-
withSQLConf(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true") {
1323+
withSQLConf(
1324+
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
1325+
CometConf.getExprAllowIncompatConfigKey(classOf[Corr]) -> "true") {
13231326
Seq("jvm", "native").foreach { cometShuffleMode =>
13241327
withSQLConf(CometConf.COMET_SHUFFLE_MODE.key -> cometShuffleMode) {
13251328
Seq(true, false).foreach { dictionary =>

0 commit comments

Comments
 (0)