refactor_bool_cast_module

Author: coderfender

native/spark-expr/src/conversion_funcs/cast.rs

@@ -1166,26 +1166,16 @@ fn cast_binary_formatter(value: &[u8]) -> String {
 /// Determines if DataFusion supports the given cast in a way that is
 /// compatible with Spark
 fn is_datafusion_spark_compatible(from_type: &DataType, to_type: &DataType) -> bool {
-    from_type == to_type
-        || match from_type {
-            DataType::Null => {
-                matches!(to_type, DataType::List(_))
-            }
-            DataType::Boolean => is_df_cast_from_bool_spark_compatible(to_type),
-            DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => {
-                matches!(
-                    to_type,
-                    DataType::Boolean
-                        | DataType::Int8
-                        | DataType::Int16
-                        | DataType::Int32
-                        | DataType::Int64
-                        | DataType::Float32
-                        | DataType::Float64
-                        | DataType::Utf8
-                )
-            }
-            DataType::Float32 | DataType::Float64 => matches!(
+    if from_type == to_type {
+        return true;
+    }
+    match from_type {
+        DataType::Null => {
+            matches!(to_type, DataType::List(_))
+        }
+        DataType::Boolean => is_df_cast_from_bool_spark_compatible(to_type),
+        DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => {
+            matches!(
                 to_type,
                 DataType::Boolean
                     | DataType::Int8
@@ -1194,34 +1184,46 @@ fn is_datafusion_spark_compatible(from_type: &DataType, to_type: &DataType) -> b
                     | DataType::Int64
                     | DataType::Float32
                     | DataType::Float64
-            ),
-            DataType::Decimal128(_, _) | DataType::Decimal256(_, _) => matches!(
+                    | DataType::Utf8
+            )
+        }
+        DataType::Float32 | DataType::Float64 => matches!(
+            to_type,
+            DataType::Boolean
+                | DataType::Int8
+                | DataType::Int16
+                | DataType::Int32
+                | DataType::Int64
+                | DataType::Float32
+                | DataType::Float64
+        ),
+        DataType::Decimal128(_, _) | DataType::Decimal256(_, _) => matches!(
+            to_type,
+            DataType::Int8
+                | DataType::Int16
+                | DataType::Int32
+                | DataType::Int64
+                | DataType::Float32
+                | DataType::Float64
+                | DataType::Decimal128(_, _)
+                | DataType::Decimal256(_, _)
+                | DataType::Utf8 // note that there can be formatting differences
+        ),
+        DataType::Utf8 => matches!(to_type, DataType::Binary),
+        DataType::Date32 => matches!(to_type, DataType::Int32 | DataType::Utf8),
+        DataType::Timestamp(_, _) => {
+            matches!(
                 to_type,
-                DataType::Int8
-                    | DataType::Int16
-                    | DataType::Int32
-                    | DataType::Int64
-                    | DataType::Float32
-                    | DataType::Float64
-                    | DataType::Decimal128(_, _)
-                    | DataType::Decimal256(_, _)
-                    | DataType::Utf8 // note that there can be formatting differences
-            ),
-            DataType::Utf8 => matches!(to_type, DataType::Binary),
-            DataType::Date32 => matches!(to_type, DataType::Int32 | DataType::Utf8),
-            DataType::Timestamp(_, _) => {
-                matches!(
-                    to_type,
-                    DataType::Int64 | DataType::Date32 | DataType::Utf8 | DataType::Timestamp(_, _)
-                )
-            }
-            DataType::Binary => {
-                // note that this is not completely Spark compatible because
-                // DataFusion only supports binary data containing valid UTF-8 strings
-                matches!(to_type, DataType::Utf8)
-            }
-            _ => false,
+                DataType::Int64 | DataType::Date32 | DataType::Utf8 | DataType::Timestamp(_, _)
+            )
         }
+        DataType::Binary => {
+            // note that this is not completely Spark compatible because
+            // DataFusion only supports binary data containing valid UTF-8 strings
+            matches!(to_type, DataType::Utf8)
+        }
+        _ => false,
+    }
 }
 
 /// Cast between struct types based on logic in