Skip to content

Commit a224e22

Browse files
andygroveclaude
andcommitted
refactor: remove unnecessary #[inline] from large functions
The #[inline] attribute on functions with loops iterating over thousands of elements provides no benefit - the function call overhead is negligible compared to loop body execution, and inlining large functions causes instruction cache pressure. Keep #[inline] only on small helper functions: - get_header_portion_in_bytes (tiny const fn) - is_null_at (small, hot path) - null_bitset_ptr (tiny accessor) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 2ea5631 commit a224e22

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

  • native/core/src/execution/shuffle

native/core/src/execution/shuffle/list.rs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ impl SparkUnsafeArray {
100100
/// Bulk append i32 values to builder.
101101
/// For non-nullable: uses slice append for optimal performance.
102102
/// For nullable: uses pointer iteration with efficient null bitset reading.
103-
#[inline]
104103
pub(crate) fn append_ints_to_builder<const NULLABLE: bool>(&self, builder: &mut Int32Builder) {
105104
let num_elements = self.num_elements;
106105
if num_elements == 0 {
@@ -132,7 +131,6 @@ impl SparkUnsafeArray {
132131
}
133132

134133
/// Bulk append i64 values to builder.
135-
#[inline]
136134
pub(crate) fn append_longs_to_builder<const NULLABLE: bool>(&self, builder: &mut Int64Builder) {
137135
let num_elements = self.num_elements;
138136
if num_elements == 0 {
@@ -163,7 +161,6 @@ impl SparkUnsafeArray {
163161
}
164162

165163
/// Bulk append i16 values to builder.
166-
#[inline]
167164
pub(crate) fn append_shorts_to_builder<const NULLABLE: bool>(
168165
&self,
169166
builder: &mut Int16Builder,
@@ -197,7 +194,6 @@ impl SparkUnsafeArray {
197194
}
198195

199196
/// Bulk append i8 values to builder.
200-
#[inline]
201197
pub(crate) fn append_bytes_to_builder<const NULLABLE: bool>(&self, builder: &mut Int8Builder) {
202198
let num_elements = self.num_elements;
203199
if num_elements == 0 {
@@ -228,7 +224,6 @@ impl SparkUnsafeArray {
228224
}
229225

230226
/// Bulk append f32 values to builder.
231-
#[inline]
232227
pub(crate) fn append_floats_to_builder<const NULLABLE: bool>(
233228
&self,
234229
builder: &mut Float32Builder,
@@ -262,7 +257,6 @@ impl SparkUnsafeArray {
262257
}
263258

264259
/// Bulk append f64 values to builder.
265-
#[inline]
266260
pub(crate) fn append_doubles_to_builder<const NULLABLE: bool>(
267261
&self,
268262
builder: &mut Float64Builder,
@@ -296,7 +290,6 @@ impl SparkUnsafeArray {
296290
}
297291

298292
/// Bulk append boolean values to builder using pointer iteration.
299-
#[inline]
300293
pub(crate) fn append_booleans_to_builder<const NULLABLE: bool>(
301294
&self,
302295
builder: &mut BooleanBuilder,
@@ -331,7 +324,6 @@ impl SparkUnsafeArray {
331324
}
332325

333326
/// Bulk append timestamp values to builder.
334-
#[inline]
335327
pub(crate) fn append_timestamps_to_builder<const NULLABLE: bool>(
336328
&self,
337329
builder: &mut TimestampMicrosecondBuilder,
@@ -365,7 +357,6 @@ impl SparkUnsafeArray {
365357
}
366358

367359
/// Bulk append date values to builder.
368-
#[inline]
369360
pub(crate) fn append_dates_to_builder<const NULLABLE: bool>(
370361
&self,
371362
builder: &mut Date32Builder,

0 commit comments

Comments
 (0)