Address review comments

- Fix documentation: skipNextRowGroup returns boolean, WrappedInputFile takes Object,
  update Utils.getColumnReader signature, fix TypeUtil reference, clarify Native.resetBatch()
- Use try-with-resources for Files.walk() in AbstractApiTest
- Remove unnecessary isNotNull() assertions in test files (getMethod/getConstructor throw if not found)
- Add @IcebergApi to BatchReader.close() and ReadOptions.Builder constructor

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: andygrove

common/src/main/java/org/apache/comet/parquet/BatchReader.java

@@ -530,6 +530,7 @@ public boolean nextBatch(int batchSize) {
     return true;
   }
 
+  @IcebergApi
   @Override
   public void close() throws IOException {
     if (columnReaders != null) {

common/src/main/java/org/apache/comet/parquet/ReadOptions.java

@@ -148,6 +148,7 @@ public ReadOptions build() {
           adjustReadRangeSkew);
     }
 
+    @IcebergApi
     public Builder(Configuration conf) {
       this.conf = conf;
       this.parallelIOEnabled =

docs/source/contributor-guide/iceberg_public_api.md

@@ -62,7 +62,7 @@ public FileReader(
 // Methods used by Iceberg
 public void setRequestedSchemaFromSpecs(List<ParquetColumnSpec> specs)
 public RowGroupReader readNextRowGroup() throws IOException
-public void skipNextRowGroup()
+public boolean skipNextRowGroup()
 public void close() throws IOException
 ```
 
@@ -94,7 +94,7 @@ Wrapper that adapts Iceberg's `InputFile` interface to Comet's file reading infr
 
 ```java
 // Constructor
-public WrappedInputFile(org.apache.iceberg.io.InputFile inputFile)
+public WrappedInputFile(Object inputFile)
 ```
 
 ### ParquetColumnSpec
@@ -223,13 +223,14 @@ General utility methods.
 
 ```java
 // Methods used by Iceberg
-public static AbstractColumnReader getColumnReader(
-    DataType sparkType,
-    ColumnDescriptor descriptor,
+public static ColumnReader getColumnReader(
+    DataType type,
+    ParquetColumnSpec columnSpec,
     CometSchemaImporter importer,
     int batchSize,
     boolean useDecimal128,
-    boolean isConstant
+    boolean useLazyMaterialization,
+    boolean useLegacyTimestamp
 )
 ```
 
@@ -308,15 +309,15 @@ Arrow's base vector interface (shaded). Used as return type in `CometVector.getV
 1. Iceberg creates a `WrappedInputFile` from its `InputFile`
 2. Creates `ReadOptions` via builder pattern
 3. Instantiates `FileReader` with the wrapped input file
-4. Converts Parquet `ColumnDescriptor`s to `ParquetColumnSpec`s using `CometTypeUtils`
+4. Converts Parquet `ColumnDescriptor`s to `ParquetColumnSpec`s using `TypeUtil`
 5. Calls `setRequestedSchemaFromSpecs()` to specify which columns to read
 6. Iterates through row groups via `readNextRowGroup()` and `skipNextRowGroup()`
 
 ### Column Reading Flow
 
 1. Creates `CometSchemaImporter` with a `RootAllocator`
 2. Uses `Utils.getColumnReader()` to create appropriate column readers
-3. Calls `reset()` and `setPageReader()` for each row group
+3. Calls `Native.resetBatch()` and `setPageReader()` for each row group
 4. Uses `BatchReader` to coordinate reading batches across all columns
 5. Retrieves results via `delegate().currentBatch()`
 

iceberg-public-api/src/test/java/org/apache/comet/iceberg/api/AbstractApiTest.java

@@ -49,7 +49,9 @@ public void setUp() throws IOException {
   @After
   public void tearDown() throws IOException {
     if (tempDir != null && Files.exists(tempDir)) {
-      Files.walk(tempDir).sorted(Comparator.reverseOrder()).map(Path::toFile).forEach(File::delete);
+      try (var stream = Files.walk(tempDir)) {
+        stream.sorted(Comparator.reverseOrder()).map(Path::toFile).forEach(File::delete);
+      }
     }
   }
 

iceberg-public-api/src/test/java/org/apache/comet/iceberg/api/parquet/AbstractColumnReaderApiTest.java

@@ -56,36 +56,31 @@ public void testImplementsAutoCloseable() {
   @Test
   public void testSetBatchSizeMethodExists() throws NoSuchMethodException {
     Method method = AbstractColumnReader.class.getMethod("setBatchSize", int.class);
-    assertThat(method).isNotNull();
     assertThat(hasIcebergApiAnnotation(method)).isTrue();
   }
 
   @Test
   public void testCloseMethodExists() throws NoSuchMethodException {
     Method method = AbstractColumnReader.class.getMethod("close");
-    assertThat(method).isNotNull();
     assertThat(hasIcebergApiAnnotation(method)).isTrue();
   }
 
   @Test
   public void testReadBatchMethodExists() throws NoSuchMethodException {
     Method method = AbstractColumnReader.class.getMethod("readBatch", int.class);
-    assertThat(method).isNotNull();
     assertThat(Modifier.isAbstract(method.getModifiers())).isTrue();
   }
 
   @Test
   public void testCurrentBatchMethodExists() throws NoSuchMethodException {
     Method method = AbstractColumnReader.class.getMethod("currentBatch");
-    assertThat(method).isNotNull();
     assertThat(Modifier.isAbstract(method.getModifiers())).isTrue();
     assertThat(method.getReturnType().getSimpleName()).isEqualTo("CometVector");
   }
 
   @Test
   public void testNativeHandleFieldExists() throws NoSuchFieldException {
     Field field = AbstractColumnReader.class.getDeclaredField("nativeHandle");
-    assertThat(field).isNotNull();
     assertThat(hasIcebergApiAnnotation(field)).isTrue();
     assertThat(Modifier.isProtected(field.getModifiers())).isTrue();
   }

iceberg-public-api/src/test/java/org/apache/comet/iceberg/api/parquet/BatchReaderApiTest.java

@@ -48,44 +48,39 @@ public void testBatchReaderIsPublic() {
   @Test
   public void testConstructorWithColumnReadersExists() throws NoSuchMethodException {
     Constructor<?> constructor = BatchReader.class.getConstructor(AbstractColumnReader[].class);
-    assertThat(constructor).isNotNull();
     assertThat(hasIcebergApiAnnotation(constructor)).isTrue();
   }
 
   @Test
   public void testSetSparkSchemaMethodExists() throws NoSuchMethodException {
     Method method = BatchReader.class.getMethod("setSparkSchema", StructType.class);
-    assertThat(method).isNotNull();
     assertThat(hasIcebergApiAnnotation(method)).isTrue();
   }
 
   @Test
   public void testGetColumnReadersMethodExists() throws NoSuchMethodException {
     Method method = BatchReader.class.getMethod("getColumnReaders");
-    assertThat(method).isNotNull();
     assertThat(hasIcebergApiAnnotation(method)).isTrue();
     assertThat(method.getReturnType()).isEqualTo(AbstractColumnReader[].class);
   }
 
   @Test
   public void testNextBatchWithSizeMethodExists() throws NoSuchMethodException {
     Method method = BatchReader.class.getMethod("nextBatch", int.class);
-    assertThat(method).isNotNull();
     assertThat(hasIcebergApiAnnotation(method)).isTrue();
     assertThat(method.getReturnType()).isEqualTo(boolean.class);
   }
 
   @Test
   public void testCurrentBatchMethodExists() throws NoSuchMethodException {
     Method method = BatchReader.class.getMethod("currentBatch");
-    assertThat(method).isNotNull();
     assertThat(method.getReturnType().getSimpleName()).isEqualTo("ColumnarBatch");
   }
 
   @Test
   public void testCloseMethodExists() throws NoSuchMethodException {
     Method method = BatchReader.class.getMethod("close");
-    assertThat(method).isNotNull();
+    assertThat(hasIcebergApiAnnotation(method)).isTrue();
   }
 
   @Test