Skip to content

Commit a53d513

Browse files
committed
fix: exclude release scratch dirs from RAT and license skill docs
The apache-rat-plugin runs during the verify phase on every install, including the six `mvnw ... install` runs in build-release-comet.sh. RAT walks the root module tree and the exclude list did not cover several untracked generated/scratch directories that accumulate during a release (Python virtualenv, docker workdir, extracted tarballs, rat report files, and the downloaded rat jar). Populated, these make each RAT pass slow and the build appears to hang. Add excludes for those paths to the Maven apache-rat-plugin config. The bash rat check (run-rat.sh) flagged files that the Maven check already skips. Reconcile the two: - Add the jni-bridge testdata backtrace/stacktrace fixtures (which moved from native/testdata) and .github/workflows/README.md to the bash rat exclude list. - Add the standard ASF license header to the five checked-in .claude/skills/*/SKILL.md files so they are properly licensed in the release tarball rather than excluded from the license check. The header is placed after the YAML frontmatter, which must stay first for the skill loader; RAT still detects it.
1 parent b26a8df commit a53d513

7 files changed

Lines changed: 104 additions & 0 deletions

File tree

.claude/skills/audit-comet-expression/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,25 @@ description: Audit an existing Comet expression for correctness and test coverag
44
argument-hint: <expression-name>
55
---
66

7+
<!--
8+
Licensed to the Apache Software Foundation (ASF) under one
9+
or more contributor license agreements. See the NOTICE file
10+
distributed with this work for additional information
11+
regarding copyright ownership. The ASF licenses this file
12+
to you under the Apache License, Version 2.0 (the
13+
"License"); you may not use this file except in compliance
14+
with the License. You may obtain a copy of the License at
15+
16+
http://www.apache.org/licenses/LICENSE-2.0
17+
18+
Unless required by applicable law or agreed to in writing,
19+
software distributed under the License is distributed on an
20+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
21+
KIND, either express or implied. See the License for the
22+
specific language governing permissions and limitations
23+
under the License.
24+
-->
25+
726
Audit the Comet implementation of the `$ARGUMENTS` expression for correctness and test coverage.
827

928
## Overview

.claude/skills/bug-triage/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,25 @@ name: bug-triage
33
description: Triage open Comet issues marked `requires-triage` per the project bug triage guide. Applies the recommended priority and area labels, removes `requires-triage`, and files a dated summary issue listing what was done. A human reviews the summary issue and closes it when satisfied.
44
---
55

6+
<!--
7+
Licensed to the Apache Software Foundation (ASF) under one
8+
or more contributor license agreements. See the NOTICE file
9+
distributed with this work for additional information
10+
regarding copyright ownership. The ASF licenses this file
11+
to you under the Apache License, Version 2.0 (the
12+
"License"); you may not use this file except in compliance
13+
with the License. You may obtain a copy of the License at
14+
15+
http://www.apache.org/licenses/LICENSE-2.0
16+
17+
Unless required by applicable law or agreed to in writing,
18+
software distributed under the License is distributed on an
19+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
20+
KIND, either express or implied. See the License for the
21+
specific language governing permissions and limitations
22+
under the License.
23+
-->
24+
625
Run a bug triage pass for the `apache/datafusion-comet` repository.
726

827
## Overview

.claude/skills/implement-comet-expression/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,25 @@ description: Use when implementing a new Spark expression in DataFusion Comet. W
44
argument-hint: <expression-name>
55
---
66

7+
<!--
8+
Licensed to the Apache Software Foundation (ASF) under one
9+
or more contributor license agreements. See the NOTICE file
10+
distributed with this work for additional information
11+
regarding copyright ownership. The ASF licenses this file
12+
to you under the Apache License, Version 2.0 (the
13+
"License"); you may not use this file except in compliance
14+
with the License. You may obtain a copy of the License at
15+
16+
http://www.apache.org/licenses/LICENSE-2.0
17+
18+
Unless required by applicable law or agreed to in writing,
19+
software distributed under the License is distributed on an
20+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
21+
KIND, either express or implied. See the License for the
22+
specific language governing permissions and limitations
23+
under the License.
24+
-->
25+
726
Implement Comet support for the `$ARGUMENTS` Spark expression.
827

928
## Background reading

.claude/skills/review-comet-pr/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,25 @@ description: Review a DataFusion Comet pull request for Spark compatibility and
44
argument-hint: <pr-number>
55
---
66

7+
<!--
8+
Licensed to the Apache Software Foundation (ASF) under one
9+
or more contributor license agreements. See the NOTICE file
10+
distributed with this work for additional information
11+
regarding copyright ownership. The ASF licenses this file
12+
to you under the Apache License, Version 2.0 (the
13+
"License"); you may not use this file except in compliance
14+
with the License. You may obtain a copy of the License at
15+
16+
http://www.apache.org/licenses/LICENSE-2.0
17+
18+
Unless required by applicable law or agreed to in writing,
19+
software distributed under the License is distributed on an
20+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
21+
KIND, either express or implied. See the License for the
22+
specific language governing permissions and limitations
23+
under the License.
24+
-->
25+
726
Review Comet PR #$ARGUMENTS
827

928
## Before You Start

.claude/skills/wire-datafusion-function/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,25 @@ description: Use when wiring an existing DataFusion or datafusion-spark function
44
argument-hint: <expression-name>
55
---
66

7+
<!--
8+
Licensed to the Apache Software Foundation (ASF) under one
9+
or more contributor license agreements. See the NOTICE file
10+
distributed with this work for additional information
11+
regarding copyright ownership. The ASF licenses this file
12+
to you under the Apache License, Version 2.0 (the
13+
"License"); you may not use this file except in compliance
14+
with the License. You may obtain a copy of the License at
15+
16+
http://www.apache.org/licenses/LICENSE-2.0
17+
18+
Unless required by applicable law or agreed to in writing,
19+
software distributed under the License is distributed on an
20+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
21+
KIND, either express or implied. See the License for the
22+
specific language governing permissions and limitations
23+
under the License.
24+
-->
25+
726
Wire Comet support for the `$ARGUMENTS` Spark expression by reusing an existing DataFusion or `datafusion-spark` function. **No native Rust is written here** — if upstream coverage is missing, stop and run `implement-comet-expression`.
827

928
## Wiring patterns

dev/release/rat_exclude_files.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
*.gitignore
22
*.dockerignore
33
.github/pull_request_template.md
4+
.github/workflows/README.md
45
.gitmodules
56
native/Cargo.lock
67
native/testdata/backtrace.txt
78
native/testdata/stacktrace.txt
89
native/core/testdata/backtrace.txt
910
native/core/testdata/stacktrace.txt
11+
native/jni-bridge/testdata/backtrace.txt
12+
native/jni-bridge/testdata/stacktrace.txt
1013
dev/copyright/scala-header.txt
1114
dev/diffs/iceberg/*.diff
1215
dev/release/requirements.txt

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1167,6 +1167,12 @@ under the License.
11671167
<exclude>docs/source/contributor-guide/*.svg</exclude>
11681168
<exclude>dev/release/rat_exclude_files.txt</exclude>
11691169
<exclude>dev/release/requirements.txt</exclude>
1170+
<exclude>dev/release/venv/**</exclude>
1171+
<exclude>dev/release/comet-rm/workdir/**</exclude>
1172+
<exclude>dev/dist/**</exclude>
1173+
<exclude>dev/release/rat.txt</exclude>
1174+
<exclude>dev/release/filtered_rat.txt</exclude>
1175+
<exclude>dev/release/*.jar</exclude>
11701176
<exclude>native/proto/src/generated/**</exclude>
11711177
<exclude>benchmarks/tpc/queries/**</exclude>
11721178
<exclude>.claude/**</exclude>

0 commit comments

Comments
 (0)