Skip to content

Commit a5453a6

Browse files
committed
fix: resolve scalafix and q9 plan-stability failures after main merge
Two issues surfaced once CI ran (the feature commits used [skip ci]): - datetime.scala: drop redundant `s` interpolators on two string literals in the date_format info hint (scalafix CHECK). - tpcds q9 golden: the info-message change makes ExtendedExplainInfo omit an empty `[COMET: ]` for a bare Spark fallback Project, so the root renders as `Project`. Update the approved plan to match.
1 parent 57dd421 commit a5453a6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

spark/src/main/scala/org/apache/comet/serde/datetime.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -688,9 +688,9 @@ object CometDateFormat extends CometExpressionSerde[DateFormatClass] {
688688
// Native `to_char` could run this if allowed; tell the user about the faster path.
689689
withInfo(
690690
expr,
691-
s"a faster native implementation is available; set " +
691+
"a faster native implementation is available; set " +
692692
s"${CometConf.getExprAllowIncompatConfigKey(getExprConfigName(expr))}=true " +
693-
s"to enable it (results may differ from Spark for non-UTC time zones)")
693+
"to enable it (results may differ from Spark for non-UTC time zones)")
694694
}
695695
// Hand the full `DateFormatClass` (with `timeZoneId` already stamped by `ResolveTimeZone`)
696696
// to the codegen dispatcher. It closure-serializes the bound tree, so non-UTC timezones

spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q9/extended.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Project [COMET: ]
1+
Project
22
: :- Subquery
33
: : +- CometNativeColumnarToRow
44
: : +- CometProject

0 commit comments

Comments
 (0)