Skip to content

Commit abc52f9

Browse files
authored
build: Stop caching libcomet in CI (#2498) (#2502)
* stop caching libcomet in CI * fix
1 parent 6023495 commit abc52f9

2 files changed

Lines changed: 6 additions & 31 deletions

File tree

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ jobs:
6363
key: ${{ runner.os }}-java-maven-${{ hashFiles('**/pom.xml') }}
6464
restore-keys: |
6565
${{ runner.os }}-java-maven-
66-
66+
- name: Build Comet
67+
run: make release
6768
- name: Cache TPC-DS generated data
6869
id: cache-tpcds-sf-1
6970
uses: actions/cache@v4
@@ -76,17 +77,6 @@ jobs:
7677
with:
7778
repository: databricks/tpcds-kit
7879
path: ./tpcds-kit
79-
- name: Build Comet
80-
run: make release
81-
- name: Upload Comet native lib
82-
uses: actions/upload-artifact@v4
83-
with:
84-
name: libcomet-${{ github.run_id }}
85-
path: |
86-
native/target/release/libcomet.so
87-
native/target/release/libcomet.dylib
88-
retention-days: 1 # remove the artifact after 1 day, only valid for this workflow
89-
overwrite: true
9080
- name: Build tpcds-kit
9181
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
9282
run: |
@@ -132,11 +122,8 @@ jobs:
132122
path: ./tpcds-sf-1
133123
key: tpcds-${{ hashFiles('.github/workflows/benchmark.yml') }}
134124
fail-on-cache-miss: true # it's always be cached as it should be generated by pre-step if not existed
135-
- name: Download Comet native lib
136-
uses: actions/download-artifact@v5
137-
with:
138-
name: libcomet-${{ github.run_id }}
139-
path: native/target/release
125+
- name: Build Comet
126+
run: make release
140127
- name: Run TPC-DS queries (Sort merge join)
141128
if: matrix.join == 'sort_merge'
142129
run: |

.github/workflows/benchmark-tpch.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -71,15 +71,6 @@ jobs:
7171
key: tpch-${{ hashFiles('.github/workflows/benchmark-tpch.yml') }}
7272
- name: Build Comet
7373
run: make release
74-
- name: Upload Comet native lib
75-
uses: actions/upload-artifact@v4
76-
with:
77-
name: libcomet-${{ github.run_id }}
78-
path: |
79-
native/target/release/libcomet.so
80-
native/target/release/libcomet.dylib
81-
retention-days: 1 # remove the artifact after 1 day, only valid for this workflow
82-
overwrite: true
8374
- name: Generate TPC-H (SF=1) table data
8475
if: steps.cache-tpch-sf-1.outputs.cache-hit != 'true'
8576
run: |
@@ -115,11 +106,8 @@ jobs:
115106
path: ./tpch
116107
key: tpch-${{ hashFiles('.github/workflows/benchmark-tpch.yml') }}
117108
fail-on-cache-miss: true # it's always be cached as it should be generated by pre-step if not existed
118-
- name: Download Comet native lib
119-
uses: actions/download-artifact@v5
120-
with:
121-
name: libcomet-${{ github.run_id }}
122-
path: native/target/release
109+
- name: Build Comet
110+
run: make release
123111
- name: Run TPC-H queries
124112
run: |
125113
SPARK_HOME=`pwd` SPARK_TPCH_DATA=`pwd`/tpch/sf1_parquet ./mvnw -B -Prelease -Dsuites=org.apache.spark.sql.CometTPCHQuerySuite test

0 commit comments

Comments
 (0)