Skip to content

Commit b1ccfd6

Browse files
committed
format
1 parent a7e9659 commit b1ccfd6

3 files changed

Lines changed: 9 additions & 24 deletions

File tree

native/core/src/execution/jni_api.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ use datafusion::{
4040
prelude::{SessionConfig, SessionContext},
4141
};
4242
use datafusion_comet_proto::spark_operator::{self, Operator};
43-
use prost::Message;
4443
use datafusion_spark::function::bitwise::bit_count::SparkBitCount;
4544
use datafusion_spark::function::bitwise::bit_get::SparkBitGet;
4645
use datafusion_spark::function::bitwise::bitwise_not::SparkBitwiseNot;
@@ -73,6 +72,7 @@ use jni::{
7372
sys::{jboolean, jdouble, jint, jlong},
7473
JNIEnv,
7574
};
75+
use prost::Message;
7676
use std::collections::HashMap;
7777
use std::path::PathBuf;
7878
use std::time::{Duration, Instant};
@@ -894,10 +894,8 @@ pub unsafe extern "system" fn Java_org_apache_comet_Native_decodeShuffleBlock(
894894
try_unwrap_or_throw(&e, |mut env| {
895895
// Parse the schema from protobuf bytes
896896
let schema_vec = env.convert_byte_array(&schema_bytes)?;
897-
let shuffle_scan =
898-
spark_operator::ShuffleScan::decode(schema_vec.as_slice()).map_err(|e| {
899-
CometError::Internal(format!("Failed to parse shuffle schema: {e}"))
900-
})?;
897+
let shuffle_scan = spark_operator::ShuffleScan::decode(schema_vec.as_slice())
898+
.map_err(|e| CometError::Internal(format!("Failed to parse shuffle schema: {e}")))?;
901899
let fields: Vec<Field> = shuffle_scan
902900
.fields
903901
.iter()

native/core/src/execution/shuffle/codec.rs

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,7 @@ fn write_array_data<W: Write>(data: &arrow::array::ArrayData, writer: &mut W) ->
7171
writer.write_all(&num_buffers.to_le_bytes())?;
7272
for buffer in data.buffers() {
7373
let len: u32 = buffer.len().try_into().map_err(|_| {
74-
DataFusionError::Execution(format!(
75-
"Buffer length {} exceeds u32::MAX",
76-
buffer.len()
77-
))
74+
DataFusionError::Execution(format!("Buffer length {} exceeds u32::MAX", buffer.len()))
7875
})?;
7976
writer.write_all(&len.to_le_bytes())?;
8077
writer.write_all(buffer.as_slice())?;
@@ -100,9 +97,7 @@ fn write_raw_batch<W: Write>(batch: &RecordBatch, writer: &mut W) -> Result<()>
10097
for col in batch.columns() {
10198
// Cast dictionary arrays to their value type
10299
let col = match col.data_type() {
103-
DataType::Dictionary(_, value_type) => {
104-
cast(col.as_ref(), value_type.as_ref())?
105-
}
100+
DataType::Dictionary(_, value_type) => cast(col.as_ref(), value_type.as_ref())?,
106101
_ => Arc::clone(col),
107102
};
108103
write_array_data(&col.to_data(), writer)?;
@@ -237,9 +232,7 @@ fn read_bytes<'a>(cursor: &mut &'a [u8], len: usize) -> Result<&'a [u8]> {
237232
/// Returns child data types for nested Arrow types.
238233
fn get_child_types(data_type: &DataType) -> Vec<DataType> {
239234
match data_type {
240-
DataType::List(field)
241-
| DataType::LargeList(field)
242-
| DataType::FixedSizeList(field, _) => {
235+
DataType::List(field) | DataType::LargeList(field) | DataType::FixedSizeList(field, _) => {
243236
vec![field.data_type().clone()]
244237
}
245238
DataType::Map(field, _) => {
@@ -709,11 +702,7 @@ mod tests {
709702

710703
let batch = RecordBatch::try_new(
711704
Arc::clone(&schema),
712-
vec![
713-
Arc::new(list_arr),
714-
Arc::new(struct_arr),
715-
Arc::new(map_arr),
716-
],
705+
vec![Arc::new(list_arr), Arc::new(struct_arr), Arc::new(map_arr)],
717706
)
718707
.unwrap();
719708

@@ -732,8 +721,7 @@ mod tests {
732721

733722
let keys = Int32Array::from(vec![Some(0), Some(1), None, Some(0)]);
734723
let values = StringArray::from(vec!["foo", "bar"]);
735-
let dict_arr =
736-
DictionaryArray::<Int32Type>::try_new(keys, Arc::new(values)).unwrap();
724+
let dict_arr = DictionaryArray::<Int32Type>::try_new(keys, Arc::new(values)).unwrap();
737725

738726
let batch =
739727
RecordBatch::try_new(Arc::clone(&dict_schema), vec![Arc::new(dict_arr)]).unwrap();

native/core/src/execution/shuffle/shuffle_writer.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,7 @@ mod test {
296296
] {
297297
let mut output = vec![];
298298
let mut cursor = Cursor::new(&mut output);
299-
let writer =
300-
ShuffleBlockWriter::try_new(schema.as_ref(), codec.clone()).unwrap();
299+
let writer = ShuffleBlockWriter::try_new(schema.as_ref(), codec.clone()).unwrap();
301300
let length = writer
302301
.write_batch(&batch, &mut cursor, &Time::default())
303302
.unwrap();

0 commit comments

Comments
 (0)