Skip to content

Commit b5b6e44

Browse files
committed
chore: apply make format
1 parent 9181e92 commit b5b6e44

5 files changed

Lines changed: 29 additions & 38 deletions

File tree

native/spark-expr/src/agg_funcs/correlation.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,8 @@ mod groups_tests {
461461
let mut a = acc(true);
462462
let v1: ArrayRef = Arc::new(Float64Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0]));
463463
let v2: ArrayRef = Arc::new(Float64Array::from(vec![2.0, 4.0, 6.0, 8.0, 10.0]));
464-
a.update_batch(&[v1, v2], &[0, 0, 0, 0, 0], None, 1).unwrap();
464+
a.update_batch(&[v1, v2], &[0, 0, 0, 0, 0], None, 1)
465+
.unwrap();
465466
let r = evaluate(&mut a);
466467
assert!((r[0].unwrap() - 1.0).abs() < 1e-12);
467468
}

native/spark-expr/src/agg_funcs/covariance.rs

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,8 @@ mod groups_tests {
540540
let mut acc = pop();
541541
let v1: ArrayRef = Arc::new(Float64Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0]));
542542
let v2: ArrayRef = Arc::new(Float64Array::from(vec![2.0, 4.0, 6.0, 8.0, 10.0]));
543-
acc.update_batch(&[v1, v2], &[0, 0, 0, 0, 0], None, 1).unwrap();
543+
acc.update_batch(&[v1, v2], &[0, 0, 0, 0, 0], None, 1)
544+
.unwrap();
544545
// pop covariance of x and 2x for x in [1..5] = 4.0
545546
assert!((evaluate(&mut acc)[0].unwrap() - 4.0).abs() < 1e-12);
546547
}
@@ -590,16 +591,17 @@ mod groups_tests {
590591
let lstate = left.state(EmitTo::All).unwrap();
591592

592593
let mut right = pop();
593-
right.update_batch(
594-
&[
595-
Arc::new(Float64Array::from(vec![4.0, 5.0, 6.0])) as ArrayRef,
596-
Arc::new(Float64Array::from(vec![8.0, 10.0, 12.0])) as ArrayRef,
597-
],
598-
&[0, 0, 0],
599-
None,
600-
1,
601-
)
602-
.unwrap();
594+
right
595+
.update_batch(
596+
&[
597+
Arc::new(Float64Array::from(vec![4.0, 5.0, 6.0])) as ArrayRef,
598+
Arc::new(Float64Array::from(vec![8.0, 10.0, 12.0])) as ArrayRef,
599+
],
600+
&[0, 0, 0],
601+
None,
602+
1,
603+
)
604+
.unwrap();
603605
let rstate = right.state(EmitTo::All).unwrap();
604606

605607
let mut merged = pop();

native/spark-expr/src/agg_funcs/stddev.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,8 @@ mod groups_tests {
274274
fn pop_stddev_single_group() {
275275
let mut acc = StddevGroupsAccumulator::new(StatsType::Population, false);
276276
let values: ArrayRef = Arc::new(Float64Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0]));
277-
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1).unwrap();
277+
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1)
278+
.unwrap();
278279
// sqrt(2.0)
279280
let result: Vec<Option<f64>> = acc
280281
.evaluate(EmitTo::All)

native/spark-expr/src/agg_funcs/variance.rs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,7 @@ impl Accumulator for VarianceAccumulator {
190190
let arr = downcast_value!(&values[0], Float64Array).iter().flatten();
191191

192192
for value in arr {
193-
let (c, m, m2) =
194-
super::welford::variance_update(self.count, self.mean, self.m2, value);
193+
let (c, m, m2) = super::welford::variance_update(self.count, self.mean, self.m2, value);
195194
self.count = c;
196195
self.mean = m;
197196
self.m2 = m2;
@@ -459,17 +458,18 @@ mod groups_tests {
459458
fn pop_variance_single_group() {
460459
let mut acc = pop_acc();
461460
let values: ArrayRef = Arc::new(Float64Array::from(vec![1.0, 2.0, 3.0, 4.0, 5.0]));
462-
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1).unwrap();
461+
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1)
462+
.unwrap();
463463
// population variance of [1..5] = 2.0
464464
assert_eq!(evaluate(&mut acc), vec![Some(2.0)]);
465465
}
466466

467467
#[test]
468468
fn pop_variance_multi_group() {
469469
let mut acc = pop_acc();
470-
let values: ArrayRef =
471-
Arc::new(Float64Array::from(vec![1.0, 2.0, 10.0, 20.0, 3.0]));
472-
acc.update_batch(&[values], &[0, 0, 1, 1, 0], None, 2).unwrap();
470+
let values: ArrayRef = Arc::new(Float64Array::from(vec![1.0, 2.0, 10.0, 20.0, 3.0]));
471+
acc.update_batch(&[values], &[0, 0, 1, 1, 0], None, 2)
472+
.unwrap();
473473
let result = evaluate(&mut acc);
474474
// group 0: pop var of [1,2,3] = 2/3; group 1: pop var of [10,20] = 25
475475
assert!((result[0].unwrap() - 2.0_f64 / 3.0).abs() < 1e-12);
@@ -486,7 +486,8 @@ mod groups_tests {
486486
Some(3.0),
487487
None,
488488
]));
489-
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1).unwrap();
489+
acc.update_batch(&[values], &[0, 0, 0, 0, 0], None, 1)
490+
.unwrap();
490491
// pop var of [1,2,3] = 2/3
491492
assert!((evaluate(&mut acc)[0].unwrap() - 2.0_f64 / 3.0).abs() < 1e-12);
492493
}
@@ -551,12 +552,8 @@ mod groups_tests {
551552
let right_state = right.state(EmitTo::All).unwrap();
552553

553554
let mut merged = pop_acc();
554-
merged
555-
.merge_batch(&left_state, &[0], None, 1)
556-
.unwrap();
557-
merged
558-
.merge_batch(&right_state, &[0], None, 1)
559-
.unwrap();
555+
merged.merge_batch(&left_state, &[0], None, 1).unwrap();
556+
merged.merge_batch(&right_state, &[0], None, 1).unwrap();
560557
let merged_result = evaluate(&mut merged)[0].unwrap();
561558

562559
assert!((single_result - merged_result).abs() < 1e-12);

native/spark-expr/src/agg_funcs/welford.rs

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,7 @@
2121
//! Spark's wire-format state.
2222
2323
#[inline]
24-
pub(crate) fn variance_update(
25-
count: f64,
26-
mean: f64,
27-
m2: f64,
28-
value: f64,
29-
) -> (f64, f64, f64) {
24+
pub(crate) fn variance_update(count: f64, mean: f64, m2: f64, value: f64) -> (f64, f64, f64) {
3025
let new_count = count + 1.0;
3126
let delta1 = value - mean;
3227
let new_mean = delta1 / new_count + mean;
@@ -36,12 +31,7 @@ pub(crate) fn variance_update(
3631
}
3732

3833
#[inline]
39-
pub(crate) fn variance_retract(
40-
count: f64,
41-
mean: f64,
42-
m2: f64,
43-
value: f64,
44-
) -> (f64, f64, f64) {
34+
pub(crate) fn variance_retract(count: f64, mean: f64, m2: f64, value: f64) -> (f64, f64, f64) {
4535
let new_count = count - 1.0;
4636
let delta1 = mean - value;
4737
let new_mean = delta1 / new_count + mean;

0 commit comments

Comments
 (0)