@@ -190,8 +190,7 @@ impl Accumulator for VarianceAccumulator {
190190 let arr = downcast_value ! ( & values[ 0 ] , Float64Array ) . iter ( ) . flatten ( ) ;
191191
192192 for value in arr {
193- let ( c, m, m2) =
194- super :: welford:: variance_update ( self . count , self . mean , self . m2 , value) ;
193+ let ( c, m, m2) = super :: welford:: variance_update ( self . count , self . mean , self . m2 , value) ;
195194 self . count = c;
196195 self . mean = m;
197196 self . m2 = m2;
@@ -459,17 +458,18 @@ mod groups_tests {
459458 fn pop_variance_single_group ( ) {
460459 let mut acc = pop_acc ( ) ;
461460 let values: ArrayRef = Arc :: new ( Float64Array :: from ( vec ! [ 1.0 , 2.0 , 3.0 , 4.0 , 5.0 ] ) ) ;
462- acc. update_batch ( & [ values] , & [ 0 , 0 , 0 , 0 , 0 ] , None , 1 ) . unwrap ( ) ;
461+ acc. update_batch ( & [ values] , & [ 0 , 0 , 0 , 0 , 0 ] , None , 1 )
462+ . unwrap ( ) ;
463463 // population variance of [1..5] = 2.0
464464 assert_eq ! ( evaluate( & mut acc) , vec![ Some ( 2.0 ) ] ) ;
465465 }
466466
467467 #[ test]
468468 fn pop_variance_multi_group ( ) {
469469 let mut acc = pop_acc ( ) ;
470- let values: ArrayRef =
471- Arc :: new ( Float64Array :: from ( vec ! [ 1.0 , 2. 0, 10. 0, 20.0 , 3.0 ] ) ) ;
472- acc . update_batch ( & [ values ] , & [ 0 , 0 , 1 , 1 , 0 ] , None , 2 ) . unwrap ( ) ;
470+ let values: ArrayRef = Arc :: new ( Float64Array :: from ( vec ! [ 1.0 , 2.0 , 10.0 , 20.0 , 3.0 ] ) ) ;
471+ acc . update_batch ( & [ values ] , & [ 0 , 0 , 1 , 1 , 0 ] , None , 2 )
472+ . unwrap ( ) ;
473473 let result = evaluate ( & mut acc) ;
474474 // group 0: pop var of [1,2,3] = 2/3; group 1: pop var of [10,20] = 25
475475 assert ! ( ( result[ 0 ] . unwrap( ) - 2.0_f64 / 3.0 ) . abs( ) < 1e-12 ) ;
@@ -486,7 +486,8 @@ mod groups_tests {
486486 Some ( 3.0 ) ,
487487 None ,
488488 ] ) ) ;
489- acc. update_batch ( & [ values] , & [ 0 , 0 , 0 , 0 , 0 ] , None , 1 ) . unwrap ( ) ;
489+ acc. update_batch ( & [ values] , & [ 0 , 0 , 0 , 0 , 0 ] , None , 1 )
490+ . unwrap ( ) ;
490491 // pop var of [1,2,3] = 2/3
491492 assert ! ( ( evaluate( & mut acc) [ 0 ] . unwrap( ) - 2.0_f64 / 3.0 ) . abs( ) < 1e-12 ) ;
492493 }
@@ -551,12 +552,8 @@ mod groups_tests {
551552 let right_state = right. state ( EmitTo :: All ) . unwrap ( ) ;
552553
553554 let mut merged = pop_acc ( ) ;
554- merged
555- . merge_batch ( & left_state, & [ 0 ] , None , 1 )
556- . unwrap ( ) ;
557- merged
558- . merge_batch ( & right_state, & [ 0 ] , None , 1 )
559- . unwrap ( ) ;
555+ merged. merge_batch ( & left_state, & [ 0 ] , None , 1 ) . unwrap ( ) ;
556+ merged. merge_batch ( & right_state, & [ 0 ] , None , 1 ) . unwrap ( ) ;
560557 let merged_result = evaluate ( & mut merged) [ 0 ] . unwrap ( ) ;
561558
562559 assert ! ( ( single_result - merged_result) . abs( ) < 1e-12 ) ;
0 commit comments