clippy

Author: parthchandra

native/core/src/execution/expressions/arithmetic.rs

@@ -102,7 +102,7 @@ impl PhysicalExpr for CheckedBinaryExpr {
                 if let Some(spark_err) = e.downcast_ref::<SparkError>() {
                     let wrapped = SparkErrorWithContext::with_context(
                         spark_err.clone(),
-                        self.query_context.as_ref().unwrap().clone(),
+                        Arc::clone(self.query_context.as_ref().unwrap()),
                     );
                     Err(DataFusionError::External(Box::new(wrapped)))
                 } else {

native/core/src/execution/planner.rs

@@ -682,6 +682,7 @@ impl PhysicalPlanner {
         }
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub fn create_binary_expr(
         &self,
         spark_expr: &Expr,

native/spark-expr/src/agg_funcs/avg_decimal.rs

@@ -429,6 +429,7 @@ struct AvgDecimalGroupsAccumulator {
 }
 
 impl AvgDecimalGroupsAccumulator {
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         return_data_type: &DataType,
         sum_data_type: &DataType,

native/spark-expr/src/conversion_funcs/boolean.rs

@@ -49,7 +49,7 @@ pub fn cast_boolean_to_decimal(
                 && e.to_string().contains("too large to store in a Decimal128")
             {
                 // Use the scaled value as it's the only non-zero value that could overflow
-                crate::error::decimal_overflow_error(scaled_val, precision, scale).into()
+                crate::error::decimal_overflow_error(scaled_val, precision, scale)
             } else {
                 SparkError::Arrow(Arc::new(e))
             }

native/spark-expr/src/conversion_funcs/cast.rs

@@ -2519,7 +2519,7 @@ impl PhysicalExpr for Cast {
                 if let Some(spark_err) = e.downcast_ref::<crate::SparkError>() {
                     let wrapped = crate::SparkErrorWithContext::with_context(
                         spark_err.clone(),
-                        self.query_context.as_ref().unwrap().clone(),
+                        Arc::clone(self.query_context.as_ref().unwrap()),
                     );
                     Err(DataFusionError::External(Box::new(wrapped)))
                 } else {

native/spark-expr/src/math_funcs/internal/checkoverflow.rs

@@ -136,9 +136,9 @@ impl PhysicalExpr for CheckOverflow {
                                     .iter()
                                     .find(|v| {
                                         if let Some(val) = v {
-                                            !arrow::array::types::Decimal128Type::validate_decimal_precision(
+                                            arrow::array::types::Decimal128Type::validate_decimal_precision(
                                                 *val, *precision, *scale
-                                            ).is_ok()
+                                            ).is_err()
                                         } else {
                                             false
                                         }
@@ -151,7 +151,7 @@ impl PhysicalExpr for CheckOverflow {
                                 // Wrap with query_context if present
                                 if let Some(ctx) = &self.query_context {
                                     DataFusionError::External(Box::new(
-                                        crate::SparkErrorWithContext::with_context(spark_error, ctx.clone())
+                                        crate::SparkErrorWithContext::with_context(spark_error, Arc::clone(ctx))
                                     ))
                                 } else {
                                     DataFusionError::External(Box::new(spark_error))
@@ -185,7 +185,7 @@ impl PhysicalExpr for CheckOverflow {
                                 DataFusionError::External(Box::new(
                                     crate::SparkErrorWithContext::with_context(
                                         spark_error,
-                                        ctx.clone(),
+                                        Arc::clone(ctx),
                                     ),
                                 ))
                             } else {