remove ignore test and use try_from_array

Author: 0lai0

native/spark-expr/src/datetime_funcs/extract_date_part.rs

@@ -16,7 +16,6 @@
 // under the License.
 
 use crate::utils::array_with_timezone;
-use arrow::array::{Array, Int32Array};
 use arrow::compute::{date_part, DatePart};
 use arrow::datatypes::{DataType, TimeUnit::Microsecond};
 use datafusion::common::{internal_datafusion_err, ScalarValue};
@@ -103,16 +102,7 @@ macro_rules! extract_date_part {
                             )),
                         )?;
                         let result = date_part(&array, DatePart::$date_part_variant)?;
-                        let result_arr = result
-                            .as_any()
-                            .downcast_ref::<Int32Array>()
-                            .expect(concat!($fn_name, " should return Int32Array"));
-
-                        let scalar_result = if result_arr.is_null(0) {
-                            ScalarValue::Int32(None)
-                        } else {
-                            ScalarValue::Int32(Some(result_arr.value(0)))
-                        };
+                        let scalar_result = ScalarValue::try_from_array(&result, 0)?;
 
                         Ok(ColumnarValue::Scalar(scalar_result))
                     }

native/spark-expr/src/datetime_funcs/unix_timestamp.rs

@@ -16,7 +16,7 @@
 // under the License.
 
 use crate::utils::array_with_timezone;
-use arrow::array::{Array, AsArray, Int64Array, PrimitiveArray};
+use arrow::array::{Array, AsArray, PrimitiveArray};
 use arrow::compute::cast;
 use arrow::datatypes::{DataType, Int64Type, TimeUnit::Microsecond};
 use datafusion::common::{internal_datafusion_err, DataFusionError, ScalarValue};
@@ -95,16 +95,7 @@ impl ScalarUDFImpl for SparkUnixTimestamp {
                     }
                 };
 
-                let int64_array = result_array
-                    .as_any()
-                    .downcast_ref::<Int64Array>()
-                    .expect("unix_timestamp should return Int64Array");
-
-                let scalar_result = if int64_array.is_null(0) {
-                    ScalarValue::Int64(None)
-                } else {
-                    ScalarValue::Int64(Some(int64_array.value(0)))
-                };
+                let scalar_result = ScalarValue::try_from_array(&result_array, 0)?;
 
                 Ok(ColumnarValue::Scalar(scalar_result))
             }

spark/src/test/resources/sql-tests/expressions/datetime/hour.sql

@@ -27,5 +27,5 @@ query
 SELECT hour(ts) FROM test_hour
 
 -- literal arguments
-query ignore(https://github.com/apache/datafusion-comet/issues/3336)
+query
 SELECT hour(timestamp('2024-01-15 00:00:00')), hour(timestamp('2024-01-15 12:30:45')), hour(timestamp('2024-01-15 23:59:59'))

spark/src/test/resources/sql-tests/expressions/datetime/minute.sql

@@ -27,5 +27,5 @@ query
 SELECT minute(ts) FROM test_minute
 
 -- literal arguments
-query ignore(https://github.com/apache/datafusion-comet/issues/3336)
+query
 SELECT minute(timestamp('2024-01-15 10:00:00')), minute(timestamp('2024-01-15 10:30:00')), minute(timestamp('2024-01-15 10:59:59'))

spark/src/test/resources/sql-tests/expressions/datetime/second.sql

@@ -27,5 +27,5 @@ query
 SELECT second(ts) FROM test_second
 
 -- literal arguments
-query ignore(https://github.com/apache/datafusion-comet/issues/3336)
+query
 SELECT second(timestamp('2024-01-15 10:30:00')), second(timestamp('2024-01-15 10:30:30')), second(timestamp('2024-01-15 10:30:59'))

spark/src/test/resources/sql-tests/expressions/datetime/unix_timestamp.sql

@@ -27,5 +27,5 @@ query
 SELECT unix_timestamp(ts) FROM test_unix_ts
 
 -- literal arguments
-query ignore(https://github.com/apache/datafusion-comet/issues/3336)
+query
 SELECT unix_timestamp(timestamp('1970-01-01 00:00:00')), unix_timestamp(timestamp('2024-06-15 10:30:45'))

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

@@ -572,28 +572,6 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
     }
   }
 
-  test("scalar hour/minute/second/unix_timestamp with ConstantFolding disabled") {
-    withSQLConf(
-      SQLConf.OPTIMIZER_EXCLUDED_RULES.key ->
-        "org.apache.spark.sql.catalyst.optimizer.ConstantFolding",
-      SESSION_LOCAL_TIMEZONE.key -> "UTC") {
-      val df = spark.sql("""
-          |SELECT
-          |  hour(timestamp('2026-04-18 04:18:45')) AS h,
-          |  minute(timestamp('2026-04-18 04:18:45')) AS m,
-          |  second(timestamp('2026-04-18 04:18:45')) AS s,
-          |  unix_timestamp(timestamp('2020-01-01 00:00:00')) AS u
-          |""".stripMargin)
-
-      val Row(h: Int, m: Int, s: Int, u: Long) = df.head()
-
-      assert(h == 4)
-      assert(m == 18)
-      assert(s == 45)
-      assert(u == 1577836800L)
-    }
-  }
-
   test("hour on int96 timestamp column") {
     import testImplicits._