Skip to content

Commit d50e34e

Browse files
andygroveandygrove
committed
update golden files
1 parent 2710ff8 commit d50e34e

213 files changed

Lines changed: 2786 additions & 2714 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36.native_datafusion/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject
22
+- Project
3-
+- Window
3+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometColumnarExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36.native_iceberg_compat/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject
22
+- Project
3-
+- Window
3+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q36/extended.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
TakeOrderedAndProject
22
+- Project
3-
+- Window
3+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
44
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47.native_datafusion/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ TakeOrderedAndProject
77
: : +- Filter
88
: : +- Window
99
: : +- Filter
10-
: : +- Window
10+
: : +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
1111
: : +- CometColumnarToRow
1212
: : +- CometSort
1313
: : +- CometColumnarExchange
@@ -44,7 +44,7 @@ TakeOrderedAndProject
4444
: : +- CometNativeScan parquet spark_catalog.default.store
4545
: +- BroadcastExchange
4646
: +- Project
47-
: +- Window
47+
: +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
4848
: +- CometColumnarToRow
4949
: +- CometSort
5050
: +- CometColumnarExchange
@@ -81,7 +81,7 @@ TakeOrderedAndProject
8181
: +- CometNativeScan parquet spark_catalog.default.store
8282
+- BroadcastExchange
8383
+- Project
84-
+- Window
84+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
8585
+- CometColumnarToRow
8686
+- CometSort
8787
+- CometColumnarExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47.native_iceberg_compat/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ TakeOrderedAndProject
77
: : +- Filter
88
: : +- Window
99
: : +- Filter
10-
: : +- Window
10+
: : +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
1111
: : +- CometColumnarToRow
1212
: : +- CometSort
1313
: : +- CometExchange
@@ -39,7 +39,7 @@ TakeOrderedAndProject
3939
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
4040
: +- BroadcastExchange
4141
: +- Project
42-
: +- Window
42+
: +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
4343
: +- CometColumnarToRow
4444
: +- CometSort
4545
: +- CometExchange
@@ -71,7 +71,7 @@ TakeOrderedAndProject
7171
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
7272
+- BroadcastExchange
7373
+- Project
74-
+- Window
74+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
7575
+- CometColumnarToRow
7676
+- CometSort
7777
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q47/extended.txt‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ TakeOrderedAndProject
77
: : +- Filter
88
: : +- Window
99
: : +- Filter
10-
: : +- Window
10+
: : +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
1111
: : +- CometColumnarToRow
1212
: : +- CometSort
1313
: : +- CometExchange
@@ -39,7 +39,7 @@ TakeOrderedAndProject
3939
: : +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
4040
: +- BroadcastExchange
4141
: +- Project
42-
: +- Window
42+
: +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
4343
: +- CometColumnarToRow
4444
: +- CometSort
4545
: +- CometExchange
@@ -71,7 +71,7 @@ TakeOrderedAndProject
7171
: +- CometScan [native_iceberg_compat] parquet spark_catalog.default.store
7272
+- BroadcastExchange
7373
+- Project
74-
+- Window
74+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
7575
+- CometColumnarToRow
7676
+- CometSort
7777
+- CometExchange

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q51.native_datafusion/explain.txt‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
== Physical Plan ==
2-
* CometColumnarToRow (42)
3-
+- CometTakeOrderedAndProject (41)
4-
+- CometFilter (40)
5-
+- CometWindowExec (39)
2+
TakeOrderedAndProject (42)
3+
+- * Filter (41)
4+
+- Window (40)
5+
+- * CometColumnarToRow (39)
66
+- CometSort (38)
77
+- CometExchange (37)
88
+- CometProject (36)
@@ -212,20 +212,20 @@ Arguments: hashpartitioning(item_sk#24, 5), ENSURE_REQUIREMENTS, CometNativeShuf
212212
Input [4]: [item_sk#24, d_date#25, web_sales#26, store_sales#27]
213213
Arguments: [item_sk#24, d_date#25, web_sales#26, store_sales#27], [item_sk#24 ASC NULLS FIRST, d_date#25 ASC NULLS FIRST]
214214

215-
(39) CometWindowExec
215+
(39) CometColumnarToRow [codegen id : 11]
216216
Input [4]: [item_sk#24, d_date#25, web_sales#26, store_sales#27]
217-
Arguments: [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29], [max(web_sales#26) windowspecdefinition(item_sk#24, d_date#25 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS web_cumulative#28, max(store_sales#27) windowspecdefinition(item_sk#24, d_date#25 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS store_cumulative#29], [item_sk#24], [d_date#25 ASC NULLS FIRST]
218217

219-
(40) CometFilter
220-
Input [6]: [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29]
221-
Condition : ((isnotnull(web_cumulative#28) AND isnotnull(store_cumulative#29)) AND (web_cumulative#28 > store_cumulative#29))
218+
(40) Window
219+
Input [4]: [item_sk#24, d_date#25, web_sales#26, store_sales#27]
220+
Arguments: [max(web_sales#26) windowspecdefinition(item_sk#24, d_date#25 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS web_cumulative#28, max(store_sales#27) windowspecdefinition(item_sk#24, d_date#25 ASC NULLS FIRST, specifiedwindowframe(RowFrame, unboundedpreceding$(), currentrow$())) AS store_cumulative#29], [item_sk#24], [d_date#25 ASC NULLS FIRST]
222221

223-
(41) CometTakeOrderedAndProject
222+
(41) Filter [codegen id : 12]
224223
Input [6]: [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29]
225-
Arguments: TakeOrderedAndProject(limit=100, orderBy=[item_sk#24 ASC NULLS FIRST,d_date#25 ASC NULLS FIRST], output=[item_sk#24,d_date#25,web_sales#26,store_sales#27,web_cumulative#28,store_cumulative#29]), [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29], 100, 0, [item_sk#24 ASC NULLS FIRST, d_date#25 ASC NULLS FIRST], [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29]
224+
Condition : ((isnotnull(web_cumulative#28) AND isnotnull(store_cumulative#29)) AND (web_cumulative#28 > store_cumulative#29))
226225

227-
(42) CometColumnarToRow [codegen id : 11]
226+
(42) TakeOrderedAndProject
228227
Input [6]: [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29]
228+
Arguments: 100, [item_sk#24 ASC NULLS FIRST, d_date#25 ASC NULLS FIRST], [item_sk#24, d_date#25, web_sales#26, store_sales#27, web_cumulative#28, store_cumulative#29]
229229

230230
===== Subqueries =====
231231

‎spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark3_5/q51.native_datafusion/extended.txt‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
1-
CometColumnarToRow
2-
+- CometTakeOrderedAndProject
3-
+- CometFilter
4-
+- CometWindowExec
1+
TakeOrderedAndProject
2+
+- Filter
3+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
4+
+- CometColumnarToRow
55
+- CometSort
66
+- CometExchange
77
+- CometProject
88
+- CometSortMergeJoin
99
:- CometSort
1010
: +- CometColumnarExchange
1111
: +- Project
12-
: +- Window
12+
: +- Window [COMET: Partition expressions must be a subset of order expressions for native window]
1313
: +- CometColumnarToRow
1414
: +- CometSort
1515
: +- CometColumnarExchange
@@ -36,7 +36,7 @@ CometColumnarToRow
3636
+- CometSort
3737
+- CometColumnarExchange
3838
+- Project
39-
+- Window
39+
+- Window [COMET: Partition expressions must be a subset of order expressions for native window]
4040
+- CometColumnarToRow
4141
+- CometSort
4242
+- CometColumnarExchange
@@ -56,4 +56,4 @@ CometColumnarToRow
5656
+- CometFilter
5757
+- CometNativeScan parquet spark_catalog.default.date_dim
5858

59-
Comet accelerated 26 out of 47 eligible operators (55%). Final plan contains 10 transitions between Spark and Comet.
59+
Comet accelerated 23 out of 47 eligible operators (48%). Final plan contains 10 transitions between Spark and Comet.

0 commit comments

Comments
 (0)