Commit db4b6eb
test(delta-regression): make Delta 2.4.0 diff install Comet extensions
Delta 2.4.0's DeltaTestSparkSession hard-codes its `extensions` override
to install ONLY DeltaSparkSessionExtension -- a workaround for SPARK-25003
(Spark 2.4.x didn't read spark.sql.extensions reliably) that was never
cleaned up even though 2.4.0 targets Spark 3.4. That override bypasses
CometDriverPlugin's mechanism for injecting CometSparkSessionExtensions
via spark.sql.extensions, so Comet's rules never install and nothing
gets rewritten -- the plan contains plain FileScan parquet + ColumnarToRow
instead of CometScan / CometFilter / etc.
Update the 2.4.0 diff so DeltaTestSparkSession ALSO iterates over
spark.sql.extensions (read from the live SparkContext conf, since
CometDriverPlugin sets the key during context init AFTER the constructor
captured sparkConf) and applies each entry as a
SparkSessionExtensions => Unit. Failures are logged to stderr so future
drift is visible.
With this:
- CometSmokeTest: both tests pass
- DeltaTimeTravelSuite: 23/23 tests pass
Spark 3.4 / Delta 2.4.0 now fully validates end-to-end, matching the
3.5/3.3.2 leg.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent bf38729 commit db4b6eb
1 file changed
Lines changed: 32 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
132 | 162 | | |
133 | 163 | | |
134 | 164 | | |
| |||
0 commit comments