Commit e56d8e5
committed
test: remove "Comet (Scan)" cases from microbenchmarks
The "Comet (Scan)" case set COMET_ENABLED=true with COMET_EXEC_ENABLED=false,
intending to isolate scan performance. With spark.comet.scan.impl=auto (the
default), CometScanRule.nativeDataFusionScan refuses to install when exec is
disabled, so the case actually measured native_iceberg_compat scan plus
Spark ColumnarToRow. Comparing it against the other Comet case (which uses
native_datafusion plus CometNativeColumnarToRow) made the result a proxy for
scan-impl choice rather than the intended isolation.
Drop the "Comet (Scan)" cases everywhere and rename the combined case to
"Comet". Update doc comments accordingly.1 parent 6f50ccf commit e56d8e5
5 files changed
Lines changed: 12 additions & 55 deletions
File tree
- spark/src/test/scala/org/apache/spark/sql/benchmark
Lines changed: 4 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
| 100 | + | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | 125 | | |
134 | 126 | | |
135 | 127 | | |
| |||
158 | 150 | | |
159 | 151 | | |
160 | 152 | | |
161 | | - | |
| 153 | + | |
162 | 154 | | |
163 | 155 | | |
164 | 156 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
Lines changed: 5 additions & 40 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
| 87 | + | |
94 | 88 | | |
95 | 89 | | |
96 | 90 | | |
| |||
128 | 122 | | |
129 | 123 | | |
130 | 124 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
| 125 | + | |
140 | 126 | | |
141 | 127 | | |
142 | 128 | | |
| |||
164 | 150 | | |
165 | 151 | | |
166 | 152 | | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
| 153 | + | |
174 | 154 | | |
175 | 155 | | |
176 | 156 | | |
| |||
199 | 179 | | |
200 | 180 | | |
201 | 181 | | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
| 182 | + | |
212 | 183 | | |
213 | 184 | | |
214 | 185 | | |
| |||
251 | 222 | | |
252 | 223 | | |
253 | 224 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
| 225 | + | |
261 | 226 | | |
262 | 227 | | |
263 | 228 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
0 commit comments