Skip to content

Commit ebe85fa

Browse files
committed
Fix test.
1 parent ba9fad8 commit ebe85fa

1 file changed

Lines changed: 14 additions & 16 deletions

File tree

spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import org.apache.spark.sql.internal.SQLConf
3131
import org.apache.comet.CometConf
3232

3333
class CometJoinSuite extends CometTestBase {
34+
3435
import testImplicits._
3536

3637
override protected def test(testName: String, testTags: Tag*)(testFun: => Any)(implicit
@@ -359,27 +360,27 @@ class CometJoinSuite extends CometTestBase {
359360
checkSparkAnswer(left.join(right, ($"left.N" === $"right.N") && ($"right.N" =!= 3), "full"))
360361

361362
checkSparkAnswer(sql("""
362-
|SELECT l.a, count(*)
363-
|FROM allNulls l FULL OUTER JOIN upperCaseData r ON (l.a = r.N)
364-
|GROUP BY l.a
363+
|SELECT l.a, count(*)
364+
|FROM allNulls l FULL OUTER JOIN upperCaseData r ON (l.a = r.N)
365+
|GROUP BY l.a
365366
""".stripMargin))
366367

367368
checkSparkAnswer(sql("""
368-
|SELECT r.N, count(*)
369-
|FROM allNulls l FULL OUTER JOIN upperCaseData r ON (l.a = r.N)
370-
|GROUP BY r.N
369+
|SELECT r.N, count(*)
370+
|FROM allNulls l FULL OUTER JOIN upperCaseData r ON (l.a = r.N)
371+
|GROUP BY r.N
371372
""".stripMargin))
372373

373374
checkSparkAnswer(sql("""
374-
|SELECT l.N, count(*)
375-
|FROM upperCaseData l FULL OUTER JOIN allNulls r ON (l.N = r.a)
376-
|GROUP BY l.N
375+
|SELECT l.N, count(*)
376+
|FROM upperCaseData l FULL OUTER JOIN allNulls r ON (l.N = r.a)
377+
|GROUP BY l.N
377378
""".stripMargin))
378379

379380
checkSparkAnswer(sql("""
380-
|SELECT r.a, count(*)
381-
|FROM upperCaseData l FULL OUTER JOIN allNulls r ON (l.N = r.a)
382-
|GROUP BY r.a
381+
|SELECT r.a, count(*)
382+
|FROM upperCaseData l FULL OUTER JOIN allNulls r ON (l.N = r.a)
383+
|GROUP BY r.a
383384
""".stripMargin))
384385
}
385386
}
@@ -422,7 +423,6 @@ class CometJoinSuite extends CometTestBase {
422423

423424
val join = joins.head
424425
val buildBatches = join.metrics("build_input_batches").value
425-
val buildRows = join.metrics("build_input_rows").value
426426

427427
// Without coalescing, build_input_batches would be ~numPartitions per task,
428428
// totaling ~numPartitions * numPartitions across all tasks.
@@ -444,9 +444,7 @@ class CometJoinSuite extends CometTestBase {
444444
assert(
445445
coalescedBatches >= numPartitions,
446446
s"Expected at least $numPartitions coalesced batches, got $coalescedBatches")
447-
assert(
448-
coalescedRows == buildRows,
449-
s"Expected $buildRows coalesced rows, got $coalescedRows")
447+
assert(coalescedRows == 10000, s"Expected 10000 coalesced rows, got $coalescedRows")
450448
}
451449
}
452450
}

0 commit comments

Comments
 (0)