Skip to content

Commit f5f3216

Browse files
committed
fix: remove redundant IgnoreCometNativeDataFusion imports from 3.4.3 diff
Remove imports of IgnoreCometNativeDataFusion in DynamicPartitionPruningSuite and FileBasedDataSourceSuite since both files are in the org.apache.spark.sql package where IgnoreCometNativeDataFusion is defined, making the import redundant and causing "permanently hidden" compilation errors.
1 parent 7fd9655 commit f5f3216

1 file changed

Lines changed: 16 additions & 18 deletions

File tree

dev/diffs/3.4.3.diff

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -417,19 +417,18 @@ index daef11ae4d6..9f3cc9181f2 100644
417417
assert(exchanges.size == 2)
418418
}
419419
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
420-
index f33432ddb6f..881eab7417c 100644
420+
index f33432ddb6f..81b83a7acd1 100644
421421
--- a/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
422422
+++ b/sql/core/src/test/scala/org/apache/spark/sql/DynamicPartitionPruningSuite.scala
423-
@@ -22,6 +22,8 @@ import org.scalatest.GivenWhenThen
423+
@@ -22,6 +22,7 @@ import org.scalatest.GivenWhenThen
424424
import org.apache.spark.sql.catalyst.expressions.{DynamicPruningExpression, Expression}
425425
import org.apache.spark.sql.catalyst.expressions.CodegenObjectFactoryMode._
426426
import org.apache.spark.sql.catalyst.plans.ExistenceJoin
427-
+import org.apache.spark.sql.IgnoreCometNativeDataFusion
428427
+import org.apache.spark.sql.comet.CometScanExec
429428
import org.apache.spark.sql.connector.catalog.{InMemoryTableCatalog, InMemoryTableWithV2FilterCatalog}
430429
import org.apache.spark.sql.execution._
431430
import org.apache.spark.sql.execution.adaptive._
432-
@@ -262,6 +264,9 @@ abstract class DynamicPartitionPruningSuiteBase
431+
@@ -262,6 +263,9 @@ abstract class DynamicPartitionPruningSuiteBase
433432
case s: BatchScanExec => s.runtimeFilters.collect {
434433
case d: DynamicPruningExpression => d.child
435434
}
@@ -439,7 +438,7 @@ index f33432ddb6f..881eab7417c 100644
439438
case _ => Nil
440439
}
441440
}
442-
@@ -755,7 +760,8 @@ abstract class DynamicPartitionPruningSuiteBase
441+
@@ -755,7 +759,8 @@ abstract class DynamicPartitionPruningSuiteBase
443442
}
444443
}
445444

@@ -449,7 +448,7 @@ index f33432ddb6f..881eab7417c 100644
449448
Given("disable broadcast pruning and disable subquery duplication")
450449
withSQLConf(
451450
SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true",
452-
@@ -1027,7 +1033,8 @@ abstract class DynamicPartitionPruningSuiteBase
451+
@@ -1027,7 +1032,8 @@ abstract class DynamicPartitionPruningSuiteBase
453452
}
454453
}
455454

@@ -459,7 +458,7 @@ index f33432ddb6f..881eab7417c 100644
459458
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "false",
460459
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
461460
withTable("large", "dimTwo", "dimThree") {
462-
@@ -1215,7 +1222,8 @@ abstract class DynamicPartitionPruningSuiteBase
461+
@@ -1215,7 +1221,8 @@ abstract class DynamicPartitionPruningSuiteBase
463462
}
464463

465464
test("SPARK-32509: Unused Dynamic Pruning filter shouldn't affect " +
@@ -469,7 +468,7 @@ index f33432ddb6f..881eab7417c 100644
469468
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
470469
withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
471470
val df = sql(
472-
@@ -1423,7 +1431,8 @@ abstract class DynamicPartitionPruningSuiteBase
471+
@@ -1423,7 +1430,8 @@ abstract class DynamicPartitionPruningSuiteBase
473472
}
474473
}
475474

@@ -479,7 +478,7 @@ index f33432ddb6f..881eab7417c 100644
479478
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "true") {
480479
val df = sql(
481480
""" WITH v as (
482-
@@ -1698,7 +1707,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
481+
@@ -1698,7 +1706,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
483482
* Check the static scan metrics with and without DPP
484483
*/
485484
test("static scan metrics",
@@ -489,7 +488,7 @@ index f33432ddb6f..881eab7417c 100644
489488
withSQLConf(SQLConf.DYNAMIC_PARTITION_PRUNING_ENABLED.key -> "true",
490489
SQLConf.DYNAMIC_PARTITION_PRUNING_REUSE_BROADCAST_ONLY.key -> "false",
491490
SQLConf.EXCHANGE_REUSE_ENABLED.key -> "false") {
492-
@@ -1729,6 +1739,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
491+
@@ -1729,6 +1738,8 @@ abstract class DynamicPartitionPruningV1Suite extends DynamicPartitionPruningDat
493492
case s: BatchScanExec =>
494493
// we use f1 col for v2 tables due to schema pruning
495494
s.output.exists(_.exists(_.argString(maxFields = 100).contains("f1")))
@@ -524,19 +523,18 @@ index a6b295578d6..91acca4306f 100644
524523

525524
test("SPARK-35884: Explain Formatted") {
526525
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
527-
index 2796b1cf154..f5e2fdfe450 100644
526+
index 2796b1cf154..db2d16798a3 100644
528527
--- a/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
529528
+++ b/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala
530-
@@ -33,6 +33,8 @@ import org.apache.spark.sql.TestingUDT.{IntervalUDT, NullData, NullUDT}
529+
@@ -33,6 +33,7 @@ import org.apache.spark.sql.TestingUDT.{IntervalUDT, NullData, NullUDT}
531530
import org.apache.spark.sql.catalyst.expressions.{AttributeReference, GreaterThan, Literal}
532531
import org.apache.spark.sql.catalyst.expressions.IntegralLiteralTestUtils.{negativeInt, positiveInt}
533532
import org.apache.spark.sql.catalyst.plans.logical.Filter
534-
+import org.apache.spark.sql.IgnoreCometNativeDataFusion
535533
+import org.apache.spark.sql.comet.{CometBatchScanExec, CometNativeScanExec, CometScanExec, CometSortMergeJoinExec}
536534
import org.apache.spark.sql.execution.{FileSourceScanLike, SimpleMode}
537535
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper
538536
import org.apache.spark.sql.execution.datasources.FilePartition
539-
@@ -499,7 +501,8 @@ class FileBasedDataSourceSuite extends QueryTest
537+
@@ -499,7 +500,8 @@ class FileBasedDataSourceSuite extends QueryTest
540538
}
541539

542540
Seq("parquet", "orc").foreach { format =>
@@ -546,31 +544,31 @@ index 2796b1cf154..f5e2fdfe450 100644
546544
withTempDir { dir =>
547545
val tableName = s"spark_25132_${format}_native"
548546
val tableDir = dir.getCanonicalPath + s"/$tableName"
549-
@@ -815,6 +818,7 @@ class FileBasedDataSourceSuite extends QueryTest
547+
@@ -815,6 +817,7 @@ class FileBasedDataSourceSuite extends QueryTest
550548
assert(bJoinExec.isEmpty)
551549
val smJoinExec = collect(joinedDF.queryExecution.executedPlan) {
552550
case smJoin: SortMergeJoinExec => smJoin
553551
+ case smJoin: CometSortMergeJoinExec => smJoin
554552
}
555553
assert(smJoinExec.nonEmpty)
556554
}
557-
@@ -875,6 +879,7 @@ class FileBasedDataSourceSuite extends QueryTest
555+
@@ -875,6 +878,7 @@ class FileBasedDataSourceSuite extends QueryTest
558556

559557
val fileScan = df.queryExecution.executedPlan collectFirst {
560558
case BatchScanExec(_, f: FileScan, _, _, _, _, _, _, _) => f
561559
+ case CometBatchScanExec(BatchScanExec(_, f: FileScan, _, _, _, _, _, _, _), _, _) => f
562560
}
563561
assert(fileScan.nonEmpty)
564562
assert(fileScan.get.partitionFilters.nonEmpty)
565-
@@ -916,6 +921,7 @@ class FileBasedDataSourceSuite extends QueryTest
563+
@@ -916,6 +920,7 @@ class FileBasedDataSourceSuite extends QueryTest
566564

567565
val fileScan = df.queryExecution.executedPlan collectFirst {
568566
case BatchScanExec(_, f: FileScan, _, _, _, _, _, _, _) => f
569567
+ case CometBatchScanExec(BatchScanExec(_, f: FileScan, _, _, _, _, _, _, _), _, _) => f
570568
}
571569
assert(fileScan.nonEmpty)
572570
assert(fileScan.get.partitionFilters.isEmpty)
573-
@@ -1100,6 +1106,9 @@ class FileBasedDataSourceSuite extends QueryTest
571+
@@ -1100,6 +1105,9 @@ class FileBasedDataSourceSuite extends QueryTest
574572
val filters = df.queryExecution.executedPlan.collect {
575573
case f: FileSourceScanLike => f.dataFilters
576574
case b: BatchScanExec => b.scan.asInstanceOf[FileScan].dataFilters

0 commit comments

Comments
 (0)