fix: Fallback reverse function with array input#2477
Closed
cfmcgrady wants to merge 4 commits into
Closed
Conversation
wForget
reviewed
Sep 29, 2025
| sql( | ||
| "create table t1 using parquet as select sequence(id, id) as c1 from range(10)") | ||
| // FIXME: Change checkSparkAnswer to checkSparkAnswerAndOperator after resolving | ||
| // https://github.com/apache/datafusion-comet/issues/2476 |
Member
There was a problem hiding this comment.
If this PR closes #2476, could you create a new issue to track adding support for ArrayType input in reverse?
Contributor
Author
There was a problem hiding this comment.
Filed a new issue #2478 for tracking reverse function with ArrayType input support.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2477 +/- ##
============================================
+ Coverage 56.12% 58.42% +2.29%
- Complexity 976 1437 +461
============================================
Files 119 146 +27
Lines 11743 13513 +1770
Branches 2251 2351 +100
============================================
+ Hits 6591 7895 +1304
- Misses 4012 4389 +377
- Partials 1140 1229 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wForget
approved these changes
Sep 29, 2025
Contributor
Author
|
Close this PR in favor of #2481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2476 .
Rationale for this change
What changes are included in this PR?
fallback
reversefunction withArrayTypeinputHow are these changes tested?
added ut