Skip to content

fix: Fallback reverse function with array input #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cfmcgrady wants to merge 4 commits into from
Closed

fix: Fallback reverse function with array input #2477

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f3ec8a
fix: Fallback reverse function with array input
cfmcgrady Sep 29, 2025
6d08728
fix style
cfmcgrady Sep 29, 2025
eff4755
address comment
cfmcgrady Sep 29, 2025
fb04747
fix ci
cfmcgrady Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,9 @@ object QueryPlanSerde extends Logging with CometExprShim {
case l @ Length(child) if child.dataType == BinaryType =>
withInfo(l, "Length on BinaryType is not supported")
None
case r @ Reverse(child) if child.dataType.isInstanceOf[ArrayType] =>
withInfo(r, "Reverse on ArrayType is not supported")
None
case expr =>
QueryPlanSerde.exprSerdeMap.get(expr.getClass) match {
case Some(handler) =>
Expand Down
10 changes: 10 additions & 0 deletions spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,4 +708,14 @@ class CometArrayExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelp
}
}
}

test("test reverse function") {
withTable("t1") {
sql(
"create table t1 using parquet as select sequence(id, id) as c1 from range(10)")
// FIXME: Change checkSparkAnswer to checkSparkAnswerAndOperator after resolving
// https://github.com/apache/datafusion-comet/issues/2476
Copy link
Copy Markdown
Member

@wForget wForget Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR closes #2476, could you create a new issue to track adding support for ArrayType input in reverse?

Copy link
Copy Markdown
Contributor Author

@cfmcgrady cfmcgrady Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed a new issue #2478 for tracking reverse function with ArrayType input support.

checkSparkAnswer("select reverse(c1) AS x FROM t1 ORDER BY c1")
}
}
}
Loading