fix: Support scalar/array args for rpad/read_side_padding#2482
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
============================================
+ Coverage 56.12% 58.40% +2.28%
- Complexity 976 1436 +460
============================================
Files 119 146 +27
Lines 11743 13510 +1767
Branches 2251 2350 +99
============================================
+ Hits 6591 7891 +1300
- Misses 4012 4389 +377
- Partials 1140 1230 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Failed spark test case: |
|
@coderfender as were working on rpad/lpad |
Thank you for the info, feel free to take over this. |
|
@wForget , If my understanding is right, you are adding support to non scalar args to |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Closes #2475.
Rationale for this change
Support full scalar/array arguments for rpad/read_side_padding
What changes are included in this PR?
Use
make_scalar_functionto convert arguments to arrays.How are these changes tested?
unit test