perf: Improve date/time microbenchmarks to avoid redundant/duplicate benchmarks#3020
Merged
Merged
Conversation
andygrove
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
============================================
+ Coverage 56.12% 59.55% +3.43%
- Complexity 976 1379 +403
============================================
Files 119 167 +48
Lines 11743 15496 +3753
Branches 2251 2569 +318
============================================
+ Hits 6591 9229 +2638
- Misses 4012 4970 +958
- Partials 1140 1297 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
approved these changes
Jan 6, 2026
| } | ||
| } | ||
|
|
||
| def timestampTruncExprBenchmark(values: Int, useDictionary: Boolean): Unit = { |
Contributor
There was a problem hiding this comment.
I think there are a lot of tests we could start removing this logic from too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Stop running redundant benchmarks (YEAR, YYYY, YY are all equivalent and do not need to be benchmarked separately)
We no longer want to test with dictionary encoded data because they are always unpacked now
What changes are included in this PR?
Removed redundant format strings:
Removed dictionary-encoded benchmarks:
This reduces the total benchmarks from 38 (19 format combinations × 2 dictionary modes) down to 10 benchmarks.
How are these changes tested?