feat: Upgrade to DataFusion 54 [do not merge]#4062
Draft
andygrove wants to merge 39 commits into
Draft
Conversation
# Conflicts: # native/Cargo.lock
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # native/Cargo.lock # native/Cargo.toml
# Conflicts: # native/Cargo.lock
# Conflicts: # native/Cargo.lock # native/Cargo.toml # native/core/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3978.
Rationale for this change
Keep the long-running
datafusion-54upgrade branch testable against the latest pre-release DataFusion. This PR is not intended to merge yet. It tracksmainplus the DF 54 API adaptations so we can exercise Comet against pre-releasebranch-54and feed bugs back upstream. It will become the merge that bumps Cometmainto DataFusion 54 once crates are released.What changes are included in this PR?
rev = "50aa138"(latest commit onbranch-54) innative/Cargo.tomlandnative/core/Cargo.toml;Cargo.lockregenerated.as_any()overrides (and strip.as_any()from call sites) since the method was dropped fromPhysicalExpr,ScalarUDFImpl,ExecutionPlan, etc.apply_expressionsoverrides. The upstream addition was reverted onbranch-54(858ad6b6a).schema_adapter.rs: derive the input field from the childColumn+ physical schema, sinceCastExpr::input_field()was removed in favor oftarget_field().MemoryPoolimpls: addDisplayandname()to satisfy the new'static + Anysupertrait requirements.COMET_EXEC_SORT_MERGE_JOIN_WITH_JOIN_FILTER_ENABLED) and mark the config deprecated.CometJoinSuite(full outer SMJ with NULL in join filter).How are these changes tested?
Existing tests.