Skip to content

chore: drop misleading ANSI-mode incompatibility note from CometSum #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coderfender merged 19 commits into from
Jun 2, 2026
+0 −2
Merged

chore: drop misleading ANSI-mode incompatibility note from CometSum #4111

Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
caccc6d
fix_incorrect_compatiblity_msg_comet_sum
Apr 27, 2026
54a83cb
fix_incorrect_compatiblity_msg_comet_sum
Apr 28, 2026
2fdb835
fix_incorrect_compatiblity_msg_comet_sum
coderfender Apr 29, 2026
27a9e8e
update_null_check
coderfender May 4, 2026
85663bf
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 4, 2026
a057ceb
address_review_comments
coderfender May 6, 2026
64d97f7
address_review_comments
coderfender May 6, 2026
7930428
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 7, 2026
f43bd8b
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 21, 2026
2ad497d
address_review_comments
coderfender May 22, 2026
a6ddfcb
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 22, 2026
b846fd9
address_review_comments
coderfender May 22, 2026
c4e06ec
address_review_comments
coderfender May 22, 2026
b2e6d03
Merge branch 'main' into fix_comet_sum_compatbility_level
andygrove May 22, 2026
1f406d2
fix_incompatible_message
coderfender May 28, 2026
3f7b21b
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 28, 2026
6e26de3
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender May 29, 2026
0a472bb
Merge branch 'main' into fix_comet_sum_compatbility_level
coderfender Jun 2, 2026
e1cd0c0
comet_sum_fix_compatibility_mode
coderfender Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spark/src/main/scala/org/apache/comet/serde/aggregates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ object CometAverage extends CometAggregateExpressionSerde[Average] {

object CometSum extends CometAggregateExpressionSerde[Sum] {

override def getIncompatibleReasons(): Seq[String] = Seq("Falls back to Spark in ANSI mode.")

Comment thread
coderfender marked this conversation as resolved.
override def convert(
aggExpr: AggregateExpression,
sum: Sum,
Expand Down
Loading