perf: use bulk-NULL semantics in split and substring, skip Vec allocation in split#4403
Merged
Conversation
…leanBufferBuilder removed. 2. Bulk-NULL in substring.rs (Utf8, LargeUtf8, Binary, LargeBinary) - into_parts then reattach input nulls. 3. LargeUtf8 offset-width fix in split.rs - LargeUtf8 input now produces LargeListArray. 4. Skip Vec in split.rs hot loop - append &str slices straight into GenericStringBuilder.
mbutrovich
changed the title
comphead
approved these changes
May 22, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @mbutrovich substring is expected to be wired from DF since DF54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4397.
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Existing tests.