ci: run miri nightly instead of on every push and PR#4411
Merged
Conversation
comphead
approved these changes
May 22, 2026
Contributor
comphead
left a comment
There was a problem hiding this comment.
Thanks @andygrove that makes a lot of sense. We would need to check miri workflow manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The miri workflow currently runs on every push to
mainand on every pull request, each gated by apaths-ignoreignore list. Miri runs are slow, and running them on every PR adds latency to the build queue for little benefit, since memory-safety regressions in native code are rare.It would be better to run these tests nightly.
What changes are included in this PR?
Replaces the
on:triggers in.github/workflows/miri.yml:pushtrigger and itspaths-ignorelistpull_requesttrigger and itspaths-ignorelistscheduletrigger running nightly at 04:00 UTC (cron: '0 4 * * *')workflow_dispatchfor manual runsThe
mirijob itself is unchanged. The cron time does not collide with the existing scheduled workflows (codeql16 4 * * 1, stale30 1 * * *).How are these changes tested?
This is a CI configuration change. The workflow remains manually triggerable via
workflow_dispatchto verify it runs, and the nightly schedule will exercise it on the normal cadence.