Skip to content

ci: run miri nightly instead of on every push and PR#4411

Merged
andygrove merged 1 commit into
apache:mainfrom
andygrove:ci-miri-nightly
May 22, 2026
Merged

ci: run miri nightly instead of on every push and PR#4411
andygrove merged 1 commit into
apache:mainfrom
andygrove:ci-miri-nightly

Conversation

@andygrove
Copy link
Copy Markdown
Member

@andygrove andygrove commented May 22, 2026

Which issue does this PR close?

N/A

Rationale for this change

The miri workflow currently runs on every push to main and on every pull request, each gated by a paths-ignore ignore list. Miri runs are slow, and running them on every PR adds latency to the build queue for little benefit, since memory-safety regressions in native code are rare.

It would be better to run these tests nightly.

What changes are included in this PR?

Replaces the on: triggers in .github/workflows/miri.yml:

  • Removes the push trigger and its paths-ignore list
  • Removes the pull_request trigger and its paths-ignore list
  • Adds a schedule trigger running nightly at 04:00 UTC (cron: '0 4 * * *')
  • Keeps workflow_dispatch for manual runs

The miri job itself is unchanged. The cron time does not collide with the existing scheduled workflows (codeql 16 4 * * 1, stale 30 1 * * *).

How are these changes tested?

This is a CI configuration change. The workflow remains manually triggerable via workflow_dispatch to verify it runs, and the nightly schedule will exercise it on the normal cadence.

Copy link
Copy Markdown
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove that makes a lot of sense. We would need to check miri workflow manually

@andygrove andygrove merged commit ccb9175 into apache:main May 22, 2026
63 checks passed
@andygrove andygrove deleted the ci-miri-nightly branch May 22, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants