Skip to content

chore: add array tests with NaN handling #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 1 commit into from
Jun 18, 2026
Merged

chore: add array tests with NaN handling #4686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,12 @@ statement
INSERT INTO test_array_distinct_double VALUES
(array(1.123, 0.1234, 1.121, 1.123, 0.1234)),
(NULL),
(array(NULL, 1.0, NULL, 2.0))
(array(NULL, 1.0, NULL, 2.0)),
(array(CAST('NaN' AS DOUBLE), CAST('NaN' AS DOUBLE))),
(array(CAST('NaN' AS DOUBLE), CAST('NaN' AS DOUBLE), 1.0, 1.0)),
(array(CAST('NaN' AS DOUBLE), NULL, CAST('NaN' AS DOUBLE), NULL, 1.0)),
(array(CAST('Infinity' AS DOUBLE), CAST('-Infinity' AS DOUBLE), CAST('Infinity' AS DOUBLE), 0.0)),
(array(0.0, -0.0, 1.0))

query
SELECT array_distinct(arr) FROM test_array_distinct_double
Expand Down Expand Up @@ -145,7 +150,12 @@ statement
INSERT INTO test_array_distinct_float VALUES
(array(CAST(1.123 AS FLOAT), CAST(0.1234 AS FLOAT), CAST(1.121 AS FLOAT), CAST(1.123 AS FLOAT))),
(NULL),
(array(CAST(NULL AS FLOAT), CAST(1.0 AS FLOAT), CAST(NULL AS FLOAT)))
(array(CAST(NULL AS FLOAT), CAST(1.0 AS FLOAT), CAST(NULL AS FLOAT))),
(array(CAST('NaN' AS FLOAT), CAST('NaN' AS FLOAT))),
(array(CAST('NaN' AS FLOAT), CAST('NaN' AS FLOAT), CAST(1.0 AS FLOAT))),
(array(CAST('NaN' AS FLOAT), NULL, CAST('NaN' AS FLOAT), NULL, CAST(1.0 AS FLOAT))),
(array(CAST('Infinity' AS FLOAT), CAST('-Infinity' AS FLOAT), CAST('Infinity' AS FLOAT), CAST(0.0 AS FLOAT))),
(array(CAST(0.0 AS FLOAT), CAST(-0.0 AS FLOAT), CAST(1.0 AS FLOAT)))

query
SELECT array_distinct(arr) FROM test_array_distinct_float
Expand Down
37 changes: 37 additions & 0 deletions spark/src/test/resources/sql-tests/expressions/array/array_except.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,40 @@ SELECT array_except(array(1, 2, 3), b) FROM test_array_except
-- literal + literal
query ignore(https://github.com/apache/datafusion-comet/issues/3646)
SELECT array_except(array(1, 2, 3), array(2, 3, 4)), array_except(array(1, 2), array()), array_except(array(), array(1)), array_except(cast(NULL as array<int>), array(1))

-- double arrays with NaN/Infinity/-0.0
statement
CREATE TABLE test_except_dbl(a array<double>, b array<double>) USING parquet

statement
INSERT INTO test_except_dbl VALUES
(array(1.0, 2.0, double('NaN')), array(2.0, double('NaN'))),
(array(double('NaN'), 1.0, 2.0), array(1.0)),
(array(double('NaN'), double('NaN'), 1.0), array(double('NaN'))),
(array(1.0, 2.0), array(double('NaN'))),
(array(double('NaN'), 1.0), array(2.0)),
(array(double('Infinity'), 1.0, double('-Infinity')), array(double('Infinity'))),
(array(double('Infinity'), double('-Infinity')), array(double('-Infinity'))),
(array(0.0, -0.0, 1.0), array(0.0)),
(array(0.0, 1.0), array(-0.0)),
(array(1.0, 2.0, NULL), array(2.0, NULL)),
(array(double('NaN'), NULL), array(NULL))

query
SELECT a, b, array_except(a, b) FROM test_except_dbl

-- float arrays with NaN/Infinity/-0.0
statement
CREATE TABLE test_except_float(a array<float>, b array<float>) USING parquet

statement
INSERT INTO test_except_float VALUES
(array(cast(1.0 as float), cast(2.0 as float), float('NaN')), array(cast(2.0 as float), float('NaN'))),
(array(float('NaN'), float('NaN'), cast(1.0 as float)), array(float('NaN'))),
(array(cast(1.0 as float), cast(2.0 as float)), array(float('NaN'))),
(array(float('Infinity'), cast(1.0 as float), float('-Infinity')), array(float('Infinity'))),
(array(cast(0.0 as float), cast(-0.0 as float), cast(1.0 as float)), array(cast(0.0 as float))),
(array(cast(1.0 as float), cast(2.0 as float), NULL), array(cast(2.0 as float), NULL))

query
SELECT a, b, array_except(a, b) FROM test_except_float
21 changes: 19 additions & 2 deletions spark/src/test/resources/sql-tests/expressions/array/array_intersect.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,15 @@ statement
CREATE TABLE test_intersect_float(a array<float>, b array<float>) USING parquet

statement
INSERT INTO test_intersect_float VALUES (array(1.5, 2.5, float('NaN')), array(2.5, float('NaN'))), (array(float('Infinity'), 1.0, float('-Infinity')), array(float('Infinity'), float('-Infinity'))), (array(cast(0.0 as float), cast(-0.0 as float)), array(cast(0.0 as float)))
INSERT INTO test_intersect_float VALUES
(array(1.5, 2.5, float('NaN')), array(2.5, float('NaN'))),
(array(float('NaN'), float('NaN'), 1.0), array(float('NaN'))),
(array(float('NaN'), 1.0, 2.0), array(float('NaN'), 2.0)),
(array(float('NaN'), 1.0), array(2.0, 3.0)),
(array(1.0, 2.0), array(float('NaN'))),
(array(float('NaN'), NULL), array(float('NaN'), NULL)),
(array(float('Infinity'), 1.0, float('-Infinity')), array(float('Infinity'), float('-Infinity'))),
(array(cast(0.0 as float), cast(-0.0 as float)), array(cast(0.0 as float)))

query
SELECT a, b, array_intersect(a, b) FROM test_intersect_float
Expand All @@ -135,7 +143,16 @@ statement
CREATE TABLE test_intersect_dbl(a array<double>, b array<double>) USING parquet

statement
INSERT INTO test_intersect_dbl VALUES (array(1.0, 2.0, double('NaN')), array(2.0, double('NaN'))), (array(double('Infinity'), 1.0, double('-Infinity')), array(double('Infinity'), double('-Infinity'))), (array(0.0, -0.0), array(0.0)), (array(1.0, 2.0, NULL), array(1.0, NULL))
INSERT INTO test_intersect_dbl VALUES
(array(1.0, 2.0, double('NaN')), array(2.0, double('NaN'))),
(array(double('NaN'), double('NaN'), 1.0), array(double('NaN'))),
(array(double('NaN'), 1.0, 2.0), array(double('NaN'), 2.0)),
(array(double('NaN'), 1.0), array(2.0, 3.0)),
(array(1.0, 2.0), array(double('NaN'))),
(array(double('NaN'), NULL), array(double('NaN'), NULL)),
(array(double('Infinity'), 1.0, double('-Infinity')), array(double('Infinity'), double('-Infinity'))),
(array(0.0, -0.0), array(0.0)),
(array(1.0, 2.0, NULL), array(1.0, NULL))

query
SELECT a, b, array_intersect(a, b) FROM test_intersect_dbl
Expand Down
41 changes: 41 additions & 0 deletions spark/src/test/resources/sql-tests/expressions/array/array_max.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,44 @@ SELECT array_max(arr) FROM test_array_max
-- literal arguments
query
SELECT array_max(array(1, 2, 3)), array_max(array()), array_max(cast(NULL as array<int>))

-- ===== DOUBLE arrays with NaN/Infinity/-0.0 =====

statement
CREATE TABLE test_array_max_double(arr array<double>) USING parquet

statement
INSERT INTO test_array_max_double VALUES
(array(CAST('NaN' AS DOUBLE), 1.0, 2.0)),
(array(1.0, CAST('NaN' AS DOUBLE), 2.0)),
(array(1.0, 2.0, CAST('NaN' AS DOUBLE))),
(array(CAST('NaN' AS DOUBLE), CAST('NaN' AS DOUBLE))),
(array(CAST('NaN' AS DOUBLE), NULL, 1.0)),
(array(CAST('Infinity' AS DOUBLE), 1.0, 2.0)),
(array(CAST('-Infinity' AS DOUBLE), 1.0, 2.0)),
(array(CAST('NaN' AS DOUBLE), CAST('Infinity' AS DOUBLE), CAST('-Infinity' AS DOUBLE))),
(array(0.0, -0.0, 1.0)),
(NULL),
(array())

query
SELECT array_max(arr) FROM test_array_max_double

-- ===== FLOAT arrays with NaN/Infinity/-0.0 =====

statement
CREATE TABLE test_array_max_float(arr array<float>) USING parquet

statement
INSERT INTO test_array_max_float VALUES
(array(CAST('NaN' AS FLOAT), CAST(1.0 AS FLOAT), CAST(2.0 AS FLOAT))),
(array(CAST('NaN' AS FLOAT), CAST('NaN' AS FLOAT))),
(array(CAST('NaN' AS FLOAT), NULL, CAST(1.0 AS FLOAT))),
(array(CAST('Infinity' AS FLOAT), CAST(1.0 AS FLOAT))),
(array(CAST('-Infinity' AS FLOAT), CAST(1.0 AS FLOAT))),
(array(CAST(0.0 AS FLOAT), CAST(-0.0 AS FLOAT))),
(NULL),
(array())

query
SELECT array_max(arr) FROM test_array_max_float
41 changes: 41 additions & 0 deletions spark/src/test/resources/sql-tests/expressions/array/array_min.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,44 @@ SELECT array_min(arr) FROM test_array_min
-- literal arguments
query
SELECT array_min(array(1, 2, 3)), array_min(array()), array_min(cast(NULL as array<int>))

-- ===== DOUBLE arrays with NaN/Infinity/-0.0 =====

statement
CREATE TABLE test_array_min_double(arr array<double>) USING parquet

statement
INSERT INTO test_array_min_double VALUES
(array(CAST('NaN' AS DOUBLE), 1.0, 2.0)),
(array(1.0, CAST('NaN' AS DOUBLE), 2.0)),
(array(1.0, 2.0, CAST('NaN' AS DOUBLE))),
(array(CAST('NaN' AS DOUBLE), CAST('NaN' AS DOUBLE))),
(array(CAST('NaN' AS DOUBLE), NULL, 1.0)),
(array(CAST('Infinity' AS DOUBLE), 1.0, 2.0)),
(array(CAST('-Infinity' AS DOUBLE), 1.0, 2.0)),
(array(CAST('NaN' AS DOUBLE), CAST('Infinity' AS DOUBLE), CAST('-Infinity' AS DOUBLE))),
(array(0.0, -0.0, 1.0)),
(NULL),
(array())

query
SELECT array_min(arr) FROM test_array_min_double

-- ===== FLOAT arrays with NaN/Infinity/-0.0 =====

statement
CREATE TABLE test_array_min_float(arr array<float>) USING parquet

statement
INSERT INTO test_array_min_float VALUES
(array(CAST('NaN' AS FLOAT), CAST(1.0 AS FLOAT), CAST(2.0 AS FLOAT))),
(array(CAST('NaN' AS FLOAT), CAST('NaN' AS FLOAT))),
(array(CAST('NaN' AS FLOAT), NULL, CAST(1.0 AS FLOAT))),
(array(CAST('Infinity' AS FLOAT), CAST(1.0 AS FLOAT))),
(array(CAST('-Infinity' AS FLOAT), CAST(1.0 AS FLOAT))),
(array(CAST(0.0 AS FLOAT), CAST(-0.0 AS FLOAT))),
(NULL),
(array())

query
SELECT array_min(arr) FROM test_array_min_float
12 changes: 11 additions & 1 deletion spark/src/test/resources/sql-tests/expressions/array/array_union.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,21 @@ statement
CREATE TABLE test_union_dbl(a array<double>, b array<double>) USING parquet

statement
INSERT INTO test_union_dbl VALUES (array(1.0, 2.0), array(2.0, 3.0)), (array(1.0, double('NaN')), array(double('NaN'), 2.0)), (array(double('Infinity'), 1.0), array(double('Infinity'))), (array(double('-Infinity')), array(double('Infinity'))), (array(0.0), array(-0.0)), (array(1.0, NULL), array(2.0, NULL))
INSERT INTO test_union_dbl VALUES (array(1.0, 2.0), array(2.0, 3.0)), (array(1.0, double('NaN')), array(double('NaN'), 2.0)), (array(double('NaN'), 1.0), array(2.0, 3.0)), (array(1.0, 2.0), array(double('NaN'), 3.0)), (array(double('NaN'), double('NaN')), array(double('NaN'))), (array(double('Infinity'), 1.0), array(double('Infinity'))), (array(double('-Infinity')), array(double('Infinity'))), (array(0.0), array(-0.0)), (array(1.0, NULL), array(2.0, NULL))

query
SELECT a, b, array_union(a, b) FROM test_union_dbl

-- float arrays with special values
statement
CREATE TABLE test_union_float(a array<float>, b array<float>) USING parquet

statement
INSERT INTO test_union_float VALUES (array(cast(1.0 as float), cast(2.0 as float)), array(cast(2.0 as float), cast(3.0 as float))), (array(cast(1.0 as float), float('NaN')), array(float('NaN'), cast(2.0 as float))), (array(float('NaN'), float('NaN')), array(float('NaN'))), (array(float('Infinity'), cast(1.0 as float)), array(float('Infinity'))), (array(float('-Infinity')), array(float('Infinity'))), (array(cast(0.0 as float)), array(cast(-0.0 as float))), (array(cast(1.0 as float), NULL), array(cast(2.0 as float), NULL))

query
SELECT a, b, array_union(a, b) FROM test_union_float

-- boolean arrays
query
SELECT array_union(array(true, false), array(false)) FROM test_union_dbl
Expand Down
Loading