feat: support MapType input for ElementAt#4697
Open
0lai0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4684.
Rationale for this change
Comet's
ElementAtserde only acceptedArrayTypeinput. Spark supports bothArrayTypeandMapType, so map lookups viaelement_at(map, key)andtry_element_at(map, key)always fell back to Spark.What changes are included in this PR?
CometElementAt.getSupportLevel: accepts MapType in addition to ArrayType.CometElementAt.convert: dispatches on input type, MapType routes to native map_extract (same path used by GetMapValue); ArrayType is unchanged.expressions.md,array_funcs.md, andmap_funcs.mdto reflect the new support.How are these changes tested?
map/element_at_map.sql: covers key found, key not found (→ NULL), null map, null key, integer key type, key type coercion, and literal map arguments.array/try_element_at.sql: the map test case now verifies native execution rather than just comparing Spark answers.ElementAtforMapTypedoes not usefailOnError, key-not-found always returns NULL regardless of ANSI mode, so no ANSI fallback is needed.