Add missing aggregate functions#1471
Merged
timsaucer merged 14 commits intoapache:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes several upstream DataFusion aggregate functions that were previously missing from the Python API, and adds unit tests to validate the new bindings.
Changes:
- Expose
groupingandpercentile_contfrom Rust bindings to the Python API. - Add Python-level wrapper for
var_populationas an alias ofvar_pop. - Add unit tests covering
percentile_cont,grouping, andvar_population.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/core/src/functions.rs |
Enables the grouping aggregate binding and adds a new percentile_cont pyfunction export. |
python/datafusion/functions.py |
Adds public Python wrappers/exports for grouping, percentile_cont, and var_population. |
python/tests/test_functions.py |
Adds unit tests for the newly exposed aggregate functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ation Expose upstream DataFusion aggregate functions that were not yet available in the Python API. Closes apache#1454. - grouping: returns grouping set membership indicator (rewritten by the ResolveGroupingFunction analyzer rule before physical planning) - percentile_cont: computes exact percentile using continuous interpolation (unlike approx_percentile_cont which uses t-digest) - var_population: alias for var_pop Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
timsaucer
force-pushed
the
feat/expose-agg-fns
branch
from
0c8dc78 to
d16cff1
Compare
ntjohnson1
approved these changes
Apr 6, 2026
Contributor
ntjohnson1
left a comment
ntjohnson1
left a comment
There was a problem hiding this comment.
Grouping examples would make it a lot clearer. Without looking around or thinking about the description more deeply the usage isn't clear to me.
Add docstring example to grouping(), parametrize percentile_cont tests, and add multi-column grouping test case. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Expose ROLLUP, CUBE, and GROUPING SETS via the DataFrame API by adding static methods on GroupingSet that construct the corresponding Expr variants. Update grouping() docstring and tests to use the new API. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ctly Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add user documentation for GroupingSet.rollup, .cube, and .grouping_sets with Pokemon dataset examples. Document the upstream alias limitation (apache/datafusion#21411) in both the grouping() docstring and the aggregation user guide. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
@ntjohnson1 I expanded the PR quite a bit to properly support grouping sets and I also updated the online documentation to explain it in a lot more detail. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ntjohnson1
approved these changes
Apr 6, 2026
Contributor
ntjohnson1
left a comment
ntjohnson1
left a comment
There was a problem hiding this comment.
The second pass helped a lot. Just a nit on some minor formatting on the examples.
…ples - Add quantile_cont as alias for percentile_cont (matches upstream) - Replace pa.concat_arrays batch pattern with collect_column() in docstrings - Add percentile_cont, quantile_cont, var_population to docs function list Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GroupingSet.rollup(), .cube(), and .grouping_sets() now accept both Expr objects and string column names, consistent with DataFrame.aggregate(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #861
Closes #925
Closes #1454
Rationale for this change
These functions exist upstream but were not exposed to the Python API
What changes are included in this PR?
Expose functions to Python API
Add unit tests
Are there any user-facing changes?
New addition only.