Fixed BACKUP parsing for redshift (#2270)

Author: romanoff

src/ast/ddl.rs

@@ -3057,6 +3057,9 @@ pub struct CreateTable {
     /// Redshift `SORTKEY` option
     /// <https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_TABLE_NEW.html>
     pub sortkey: Option<Vec<Expr>>,
+    /// Redshift `BACKUP` option: `BACKUP { YES | NO }`
+    /// <https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_TABLE_NEW.html>
+    pub backup: Option<bool>,
 }
 
 impl fmt::Display for CreateTable {
@@ -3360,6 +3363,9 @@ impl fmt::Display for CreateTable {
         if self.strict {
             write!(f, " STRICT")?;
         }
+        if let Some(backup) = self.backup {
+            write!(f, " BACKUP {}", if backup { "YES" } else { "NO" })?;
+        }
         if let Some(diststyle) = &self.diststyle {
             write!(f, " DISTSTYLE {diststyle}")?;
         }

src/ast/helpers/stmt_create_table.rs

@@ -181,6 +181,8 @@ pub struct CreateTableBuilder {
     pub distkey: Option<Expr>,
     /// Redshift `SORTKEY` option.
     pub sortkey: Option<Vec<Expr>>,
+    /// Redshift `BACKUP` option.
+    pub backup: Option<bool>,
 }
 
 impl CreateTableBuilder {
@@ -245,6 +247,7 @@ impl CreateTableBuilder {
             diststyle: None,
             distkey: None,
             sortkey: None,
+            backup: None,
         }
     }
     /// Set `OR REPLACE` for the CREATE TABLE statement.
@@ -548,6 +551,11 @@ impl CreateTableBuilder {
         self.sortkey = sortkey;
         self
     }
+    /// Set the Redshift `BACKUP` option.
+    pub fn backup(mut self, backup: Option<bool>) -> Self {
+        self.backup = backup;
+        self
+    }
     /// Consume the builder and produce a `CreateTable`.
     pub fn build(self) -> CreateTable {
         CreateTable {
@@ -609,6 +617,7 @@ impl CreateTableBuilder {
             diststyle: self.diststyle,
             distkey: self.distkey,
             sortkey: self.sortkey,
+            backup: self.backup,
         }
     }
 }
@@ -689,6 +698,7 @@ impl From<CreateTable> for CreateTableBuilder {
             diststyle: table.diststyle,
             distkey: table.distkey,
             sortkey: table.sortkey,
+            backup: table.backup,
         }
     }
 }

src/ast/spans.rs

@@ -589,6 +589,7 @@ impl Spanned for CreateTable {
             diststyle: _,
             distkey: _,
             sortkey: _,
+            backup: _,
         } = self;
 
         union_spans(

src/keywords.rs

@@ -145,6 +145,7 @@ define_keywords!(
     AVG,
     AVG_ROW_LENGTH,
     AVRO,
+    BACKUP,
     BACKWARD,
     BASE64,
     BASE_LOCATION,
@@ -1171,6 +1172,7 @@ define_keywords!(
     XOR,
     YEAR,
     YEARS,
+    YES,
     ZONE,
     ZORDER,
     ZSTD

src/parser/mod.rs

@@ -8443,6 +8443,14 @@ impl<'a> Parser<'a> {
 
         let strict = self.parse_keyword(Keyword::STRICT);
 
+        // Redshift: BACKUP YES|NO
+        let backup = if self.parse_keyword(Keyword::BACKUP) {
+            let keyword = self.expect_one_of_keywords(&[Keyword::YES, Keyword::NO])?;
+            Some(keyword == Keyword::YES)
+        } else {
+            None
+        };
+
         // Redshift: DISTSTYLE, DISTKEY, SORTKEY
         let diststyle = if self.parse_keyword(Keyword::DISTSTYLE) {
             Some(self.parse_dist_style()?)
@@ -8505,6 +8513,7 @@ impl<'a> Parser<'a> {
             .table_options(create_table_config.table_options)
             .primary_key(primary_key)
             .strict(strict)
+            .backup(backup)
             .diststyle(diststyle)
             .distkey(distkey)
             .sortkey(sortkey)

tests/sqlparser_duckdb.rs

@@ -793,6 +793,7 @@ fn test_duckdb_union_datatype() {
             diststyle: Default::default(),
             distkey: Default::default(),
             sortkey: Default::default(),
+            backup: Default::default(),
         }),
         stmt
     );

tests/sqlparser_mssql.rs

@@ -2011,6 +2011,7 @@ fn parse_create_table_with_valid_options() {
                 diststyle: None,
                 distkey: None,
                 sortkey: None,
+                backup: None,
             })
         );
     }
@@ -2184,6 +2185,7 @@ fn parse_create_table_with_identity_column() {
                 diststyle: None,
                 distkey: None,
                 sortkey: None,
+                backup: None,
             }),
         );
     }

tests/sqlparser_postgres.rs

@@ -6503,6 +6503,7 @@ fn parse_trigger_related_functions() {
             diststyle: None,
             distkey: None,
             sortkey: None,
+            backup: None,
         }
     );
 

tests/sqlparser_redshift.rs

@@ -500,3 +500,14 @@ fn test_alter_table_alter_sortkey() {
     redshift().verified_stmt("ALTER TABLE users ALTER SORTKEY(created_at)");
     redshift().verified_stmt("ALTER TABLE users ALTER SORTKEY(c1, c2)");
 }
+
+#[test]
+fn test_create_table_backup() {
+    redshift().verified_stmt("CREATE TABLE public.users (id INT, name VARCHAR(255)) BACKUP YES");
+
+    redshift().verified_stmt("CREATE TABLE staging.events (event_id INT) BACKUP NO");
+
+    redshift().verified_stmt(
+        "CREATE TABLE public.users_backup_test BACKUP YES DISTSTYLE AUTO AS SELECT id, name, email FROM public.users",
+    );
+}