Address linter errors.

Author: Roman Borschel

src/ast/mod.rs

@@ -2273,7 +2273,7 @@ impl fmt::Display for ConditionalStatementBlock {
             write!(f, " THEN")?;
         }
 
-        if conditional_statements.statements().len() > 0 {
+        if !conditional_statements.statements().is_empty() {
             write!(f, " {conditional_statements}")?;
         }
 
@@ -2309,7 +2309,7 @@ impl fmt::Display for ConditionalStatements {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
             ConditionalStatements::Sequence { statements } => {
-                if statements.len() > 0 {
+                if !statements.is_empty() {
                     format_statement_list(f, statements)?;
                 }
                 Ok(())

src/ast/spans.rs

@@ -761,13 +761,8 @@ impl Spanned for IfStatement {
         union_spans(
             iter::once(if_block.span())
                 .chain(elseif_blocks.iter().map(|b| b.span()))
-                .chain(else_block.as_ref().map(|b| b.span()).into_iter())
-                .chain(
-                    end_token
-                        .as_ref()
-                        .map(|AttachedToken(t)| t.span)
-                        .into_iter(),
-                ),
+                .chain(else_block.as_ref().map(|b| b.span()))
+                .chain(end_token.as_ref().map(|AttachedToken(t)| t.span)),
         )
     }
 }
@@ -798,13 +793,8 @@ impl Spanned for ConditionalStatementBlock {
 
         union_spans(
             iter::once(start_token.span)
-                .chain(condition.as_ref().map(|c| c.span()).into_iter())
-                .chain(
-                    then_token
-                        .as_ref()
-                        .map(|AttachedToken(t)| t.span)
-                        .into_iter(),
-                )
+                .chain(condition.as_ref().map(|c| c.span()))
+                .chain(then_token.as_ref().map(|AttachedToken(t)| t.span))
                 .chain(iter::once(conditional_statements.span())),
         )
     }

src/dialect/mssql.rs

@@ -139,12 +139,11 @@ impl MsSqlDialect {
 
         let condition = parser.parse_expr()?;
 
-        let if_block;
-        if parser.peek_keyword(Keyword::BEGIN) {
+        let if_block = if parser.peek_keyword(Keyword::BEGIN) {
             let begin_token = parser.expect_keyword(Keyword::BEGIN)?;
             let statements = self.parse_statement_list(parser, Some(Keyword::END))?;
             let end_token = parser.expect_keyword(Keyword::END)?;
-            if_block = ConditionalStatementBlock {
+            ConditionalStatementBlock {
                 start_token: AttachedToken(if_token),
                 condition: Some(condition),
                 then_token: None,
@@ -153,18 +152,18 @@ impl MsSqlDialect {
                     statements,
                     end_token: AttachedToken(end_token),
                 },
-            };
+            }
         } else {
             let stmt = parser.parse_statement()?;
-            if_block = ConditionalStatementBlock {
+            ConditionalStatementBlock {
                 start_token: AttachedToken(if_token),
                 condition: Some(condition),
                 then_token: None,
                 conditional_statements: ConditionalStatements::Sequence {
                     statements: vec![stmt],
                 },
-            };
-        }
+            }
+        };
 
         while let Token::SemiColon = parser.peek_token_ref().token {
             parser.advance_token();