Skip to content

Commit b82f111

Browse files
Refactored requests from PR
1 parent d4868ba commit b82f111

File tree

3 files changed

+3
-38
lines changed

3 files changed

+3
-38
lines changed

src/ast/mod.rs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3967,18 +3967,7 @@ pub enum Statement {
39673967
sequence_options: Vec<SequenceOptions>,
39683968
owned_by: Option<ObjectName>,
39693969
},
3970-
/// ```sql
3971-
/// CREATE DOMAIN name [ AS ] data_type
3972-
/// [ COLLATE collation ]
3973-
/// [ DEFAULT expression ]
3974-
/// [ domain_constraint [ ... ] ]
3975-
///
3976-
/// where domain_constraint is:
3977-
///
3978-
/// [ CONSTRAINT constraint_name ]
3979-
/// { NOT NULL | NULL | CHECK (expression) }
3980-
/// ```
3981-
/// See [PostgreSQL](https://www.postgresql.org/docs/current/sql-createdomain.html)
3970+
/// A `CREATE DOMAIN` statement.
39823971
CreateDomain(CreateDomain),
39833972
/// ```sql
39843973
/// CREATE TYPE <name>

src/parser/mod.rs

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5896,20 +5896,8 @@ impl<'a> Parser<'a> {
58965896
Ok(owner)
58975897
}
58985898

5899-
/// ```sql
5900-
/// CREATE DOMAIN name [ AS ] data_type
5901-
/// [ COLLATE collation ]
5902-
/// [ DEFAULT expression ]
5903-
/// [ domain_constraint [ ... ] ]
5904-
///
5905-
/// where domain_constraint is:
5906-
///
5907-
/// [ CONSTRAINT constraint_name ]
5908-
/// { NOT NULL | NULL | CHECK (expression) }
5909-
/// ```
5910-
///
5911-
/// [PostgreSQL Documentation](https://www.postgresql.org/docs/current/sql-createdomain.html)
5912-
pub fn parse_create_domain(&mut self) -> Result<Statement, ParserError> {
5899+
/// Parses a [Statement::CreateDomain] statement.
5900+
fn parse_create_domain(&mut self) -> Result<Statement, ParserError> {
59135901
let name = self.parse_object_name(false)?;
59145902
self.expect_keyword_is(Keyword::AS)?;
59155903
let data_type = self.parse_data_type()?;

tests/sqlparser_postgres.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5099,10 +5099,7 @@ fn parse_create_domain() {
50995099
});
51005100

51015101
assert_eq!(pg().verified_stmt(sql1), expected);
5102-
}
51035102

5104-
#[test]
5105-
fn parse_create_domain_with_collation() {
51065103
let sql2 = "CREATE DOMAIN my_domain AS INTEGER COLLATE \"en_US\" CHECK (VALUE > 0)";
51075104
let expected = Statement::CreateDomain(CreateDomain {
51085105
name: ObjectName::from(vec![Ident::new("my_domain")]),
@@ -5120,10 +5117,7 @@ fn parse_create_domain_with_collation() {
51205117
});
51215118

51225119
assert_eq!(pg().verified_stmt(sql2), expected);
5123-
}
51245120

5125-
#[test]
5126-
fn parse_create_domain_with_default() {
51275121
let sql3 = "CREATE DOMAIN my_domain AS INTEGER DEFAULT 1 CHECK (VALUE > 0)";
51285122
let expected = Statement::CreateDomain(CreateDomain {
51295123
name: ObjectName::from(vec![Ident::new("my_domain")]),
@@ -5141,10 +5135,7 @@ fn parse_create_domain_with_default() {
51415135
});
51425136

51435137
assert_eq!(pg().verified_stmt(sql3), expected);
5144-
}
51455138

5146-
#[test]
5147-
fn parse_create_domain_with_default_and_collation() {
51485139
let sql4 = "CREATE DOMAIN my_domain AS INTEGER COLLATE \"en_US\" DEFAULT 1 CHECK (VALUE > 0)";
51495140
let expected = Statement::CreateDomain(CreateDomain {
51505141
name: ObjectName::from(vec![Ident::new("my_domain")]),
@@ -5162,10 +5153,7 @@ fn parse_create_domain_with_default_and_collation() {
51625153
});
51635154

51645155
assert_eq!(pg().verified_stmt(sql4), expected);
5165-
}
51665156

5167-
#[test]
5168-
fn parse_create_domain_with_named_constraint() {
51695157
let sql5 = "CREATE DOMAIN my_domain AS INTEGER CONSTRAINT my_constraint CHECK (VALUE > 0)";
51705158
let expected = Statement::CreateDomain(CreateDomain {
51715159
name: ObjectName::from(vec![Ident::new("my_domain")]),

0 commit comments

Comments
 (0)