MySQL create table options: optional DEFAULT keyword, CHARACTER SET longhand#1783
Closed
MohamedAbdeen21 wants to merge 1 commit intoapache:mainfrom
Closed
MySQL create table options: optional DEFAULT keyword, CHARACTER SET longhand#1783MohamedAbdeen21 wants to merge 1 commit intoapache:mainfrom
MohamedAbdeen21 wants to merge 1 commit intoapache:mainfrom
Conversation
MohamedAbdeen21
commented
Mar 30, 2025
| "CREATE TABLE foo (id INT(11)) CHARACTER SET utf8mb3 DEFAULT COLLATE utf8mb4_0900_ai_ci"; | ||
| let expected = | ||
| "CREATE TABLE foo (id INT(11)) DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb4_0900_ai_ci"; | ||
| match mysql().one_statement_parses_to(sql, expected) { |
Contributor
Author
There was a problem hiding this comment.
If we want to switch this to use verified_stmt instead, we will need to replace both collate and charset fields in CreateTable with structs to capture the exact syntax used (was default keyword and/or assignment operator used? shorthand CHARSET instead of CHARACTER SET?).
Contributor
Author
|
Closed in favor of #1747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per MySQL docs both
DEFAULTand=are optional forCHARACTER SETandCOLLATEoptions.Also, CHARSET is an alias for CHARACTER SET, so both should be parsed.