Merged
Conversation
Contributor
Author
|
Refactored analogously to what was requested in pull request #1828 |
iffyio
reviewed
May 3, 2025
iffyio
changed the title
CREATE DOMAIN
iffyio
approved these changes
May 4, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
cc @alamb
Contributor
|
Werd! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
CREATE DOMAINsyntax and the tests to validate whether the implementation is correct. It closes issue #1829.IMPORTANT: this pull request may collide with #1828, as I had to add the keyword
DOMAINin both of them.Best,
Luca