Added support for SQLite triggers#2037
Conversation
|
Regarding commit c893bda, it should be noted that the |
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
|
Is there anything else needed to be done for this PR? @iffyio |
|
@LucaCappelletti94 could you take a look at this comment? |
|
Hi @iffyio, I replied to it here: #2037 (comment) |
|
@LucaCappelletti94 the link takes me to the top of the page not sure why but I'm unable to find the comment in this case |
@iffyio Here follows the comment:
|
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
This PR:
CREATE TRIGGERfor SQLite dialect, which was early blocked by a dialect guardTEMPORARYkeyword, which may be desirable if we want to raise errors in other dialect ifTEMPtriggers are provided.FOR EACH ROWin triggers, which is optional in SQLiteCREATE TRIGGERcases in SQLite.DROP TRIGGERfor SQLite dialect, which was early blocked by a dialect guardDROP TRIGGERcase in SQLite.Closes issue #2023