Conversation
|
Do consider adding some tests for the newly added code. |
|
Have you looked at tests/sqlparser_common.rs? The changes there represent all cases for the newly added options. |
src/ast/mod.rs
Outdated
| write!( | ||
| f, | ||
| "{}", | ||
| match *enabled { | ||
| Some(true) => " TRUE", | ||
| Some(false) => " FALSE", | ||
| _ => "", | ||
| } | ||
| ) |
There was a problem hiding this comment.
this looks like it can be simplified as?
if let Some(enabled) = enabled {
write!()
}
src/parser/mod.rs
Outdated
| Keyword::ON, | ||
| Keyword::OFF, | ||
| ]) { | ||
| Some(Keyword::PRESET) => None, |
There was a problem hiding this comment.
is this branch valid, we don't seem to expect it in the keywords?
|
As far as I can understand, the changes made in |
It tests the full SQL to AST and AST to SQL flow. The new options are added to an existing flow, not introducing new AST structs. The existing structs are covered in existing tests. |
yoavcloud
force-pushed
the
redshift_copy_options_2510
branch
from
e44e613 to
72d7c5d
Compare
3 participants
Added support for REMOVEQUOTES, COMPUPDATE and STATUPDATE.