-
Notifications
You must be signed in to change notification settings - Fork 710
feat: add PostgreSQL EXCLUDE constraint parsing #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fmguerreiro
wants to merge
19
commits into
apache:main
Choose a base branch
from
fmguerreiro:feat/exclude-constraint-upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d266014
feat(ast): add ExclusionConstraint and ExclusionElement types
fmguerreiro a957bb7
feat(parser): parse EXCLUDE constraints in CREATE TABLE and ALTER TABLE
fmguerreiro 6f47488
test: add EXCLUDE constraint parsing tests
fmguerreiro 17cbba9
refactor: clean up exclusion constraint additions for upstream review
fmguerreiro a0cacb2
fix: tighten exclusion constraint parsing per upstream review
fmguerreiro a189d8f
feat(ast): extend ExclusionElement with operator_class and order options
fmguerreiro dddb2ce
fix(parser): gate EXCLUDE by PG dialect; parse OPERATOR() and element…
fmguerreiro 2d37749
test: realign EXCLUDE tests to current APIs and expand coverage
fmguerreiro 90803e0
refactor: reuse parse_order_by_expr_inner and tighten exclude tests
fmguerreiro 442e196
fix: resolve collapsible_match clippy lints in parser
fmguerreiro d8e35d9
Merge remote-tracking branch 'origin/feat/exclude-constraint-upstream…
fmguerreiro e02613e
style: cargo fmt
fmguerreiro 837b5a0
fix: remove accidentally committed worktree dirs
fmguerreiro 228c969
feat(ast): model exclusion operator as an enum
fmguerreiro abfc1c6
Merge remote-tracking branch 'origin/feat/exclude-constraint-upstream…
fmguerreiro 460c098
fix: address review feedback on exclusion constraint PR
fmguerreiro f699bea
fix: merge review feedback with upstream EXCLUDE changes
fmguerreiro fc8b794
Merge remote-tracking branch 'upstream/main' into feat/exclude-constr…
fmguerreiro 60b5fd2
fix(exclude): address upstream review feedback on PR #2307
fmguerreiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,4 +18,4 @@ Cargo.lock | |
|
|
||
| *.swp | ||
|
|
||
| .DS_store | ||
| .DS_store.worktrees/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 60b5fd2.