Skip to content

Commit 0ee951c

Browse files
committed
improve tests to cover BlockedNullState.
1 parent 2cd5ea9 commit 0ee951c

2 files changed

Lines changed: 288 additions & 91 deletions

File tree

datafusion/functions-aggregate-common/src/aggregate/groups_accumulator.rs

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -554,37 +554,3 @@ impl GroupIndexOperations for FlatGroupIndexOperations {
554554
packed_index
555555
}
556556
}
557-
558-
// #[cfg(test)]
559-
// mod tests {
560-
// use super::*;
561-
562-
// #[test]
563-
// fn test_blocked_group_index_build() {
564-
// let group_index1 = 1;
565-
// let group_index2 = (42_u64 << 32) | 2;
566-
// let group_index3 = ((u32::MAX as u64) << 32) | 3;
567-
568-
// let index_builder = BlockedGroupIndexBuilder::new(false);
569-
// let flat1 = index_builder.build(group_index1 as usize);
570-
// let flat2 = index_builder.build(group_index2 as usize);
571-
// let flat3 = index_builder.build(group_index3 as usize);
572-
// let expected1 = BlockedGroupIndex::new_from_parts(0, group_index1);
573-
// let expected2 = BlockedGroupIndex::new_from_parts(0, group_index2);
574-
// let expected3 = BlockedGroupIndex::new_from_parts(0, group_index3);
575-
// assert_eq!(flat1, expected1);
576-
// assert_eq!(flat2, expected2);
577-
// assert_eq!(flat3, expected3);
578-
579-
// let index_builder = BlockedGroupIndexBuilder::new(true);
580-
// let blocked1 = index_builder.build(group_index1 as usize);
581-
// let blocked2 = index_builder.build(group_index2 as usize);
582-
// let blocked3 = index_builder.build(group_index3 as usize);
583-
// let expected1 = BlockedGroupIndex::new_from_parts(0, 1);
584-
// let expected2 = BlockedGroupIndex::new_from_parts(42, 2);
585-
// let expected3 = BlockedGroupIndex::new_from_parts(u32::MAX, 3);
586-
// assert_eq!(blocked1, expected1);
587-
// assert_eq!(blocked2, expected2);
588-
// assert_eq!(blocked3, expected3);
589-
// }
590-
// }

0 commit comments

Comments
 (0)