Commit 240fbdb
authored
fix: suppress nondeterministic metrics in agg_dyn_e2e sqllogictest (#21657)
## Which issue does this PR close?
- Closes #.
## Rationale for this change
PR #21620 (commit 5c653be) ported
`test_aggregate_dynamic_filter_parquet_e2e` from Rust to sqllogictest
using `analyze_categories = 'rows'`, which includes exact pushdown
metrics. These metrics are nondeterministic under parallel execution —
the order in which Partial aggregates publish dynamic filter updates
races against when the scan reads each partition — so the expected
output is flaky.
Noticed on #21629 ([CI
run](https://github.com/apache/datafusion/actions/runs/24472961090/job/71518239089?pr=21629))
and confirmed on main ([CI
run](https://github.com/apache/datafusion/actions/runs/24467213913/job/71497866154)).
## What changes are included in this PR?
Switch the `agg_dyn_e2e` test to `analyze_level = summary` +
`analyze_categories = 'none'`, suppressing nondeterministic metrics.
This matches the approach already used by the other aggregate dynamic
filter tests in the same file. The original Rust test only asserted
`matched < 4` (i.e. some pruning happened); the important invariant —
that the `DynamicFilter [ column1@0 > 4 ]` text and pruning predicate
are correct — is still verified.
## Are these changes tested?
Yes — the test itself is what is being fixed.
## Are there any user-facing changes?
No.1 parent 7bf39b5 commit 240fbdb
File tree
1 file changed
+16
-5
lines changed- datafusion/sqllogictest/test_files
1 file changed
+16
-5
lines changedLines changed: 16 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
221 | 226 | | |
222 | | - | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
223 | 231 | | |
224 | 232 | | |
225 | 233 | | |
226 | 234 | | |
227 | 235 | | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
232 | 240 | | |
233 | 241 | | |
234 | 242 | | |
235 | 243 | | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
236 | 247 | | |
237 | 248 | | |
238 | 249 | | |
| |||
0 commit comments