remove tests assuming string->int coercion is impossible

Author: zyuiop

datafusion/expr-common/src/type_coercion/binary/tests/arithmetic.rs

@@ -18,20 +18,6 @@
 use super::*;
 use datafusion_common::assert_contains;
 
-#[test]
-fn test_coercion_error() -> Result<()> {
-    let coercer =
-        BinaryTypeCoercer::new(&DataType::Float32, &Operator::Plus, &DataType::Utf8);
-    let result_type = coercer.get_input_types();
-
-    let e = result_type.unwrap_err();
-    assert_eq!(
-        e.strip_backtrace(),
-        "Error during planning: Cannot coerce arithmetic expression Float32 + Utf8 to valid types"
-    );
-    Ok(())
-}
-
 #[test]
 fn test_date_timestamp_arithmetic_error() -> Result<()> {
     let (lhs, rhs) = BinaryTypeCoercer::new(

datafusion/sql/tests/cases/diagnostic.rs

@@ -202,20 +202,6 @@ fn test_ambiguous_reference() -> Result<()> {
     Ok(())
 }
 
-#[test]
-fn test_incompatible_types_binary_arithmetic() -> Result<()> {
-    let query = "SELECT /*whole+left*/id/*left*/ + /*right*/first_name/*right+whole*/ FROM person";
-    let spans = get_spans(query);
-    let diag = do_query(query);
-    assert_snapshot!(diag.message, @"expressions have incompatible types");
-    assert_eq!(diag.span, Some(spans["whole"]));
-    assert_snapshot!(diag.notes[0].message, @"has type UInt32");
-    assert_eq!(diag.notes[0].span, Some(spans["left"]));
-    assert_snapshot!(diag.notes[1].message, @"has type Utf8");
-    assert_eq!(diag.notes[1].span, Some(spans["right"]));
-    Ok(())
-}
-
 #[test]
 fn test_field_not_found_suggestion() -> Result<()> {
     let query = "SELECT /*whole*/first_na/*whole*/ FROM person";