fix: ProjectionPushdown internal error on NestedLoopJoin mark joins (#22902)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Closes #22901.

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

A query whose subquery becomes a mark join (`LeftMark`/`RightMark`) can
panic during the `ProjectionPushdown` physical optimization with an
internal assertion error.

The pushdown helper `try_pushdown_through_join` assumes the join output
schema is the plain concatenation of its two children (`left ++ right`)
and uses `join_table_borders` to split the projected columns into a left
group and a right group by column index. Mark joins break this
assumption: they append an extra `mark` boolean column that does not
originate from either child, so the column-index split misroutes columns
to the wrong side and the subsequent child-projection rewrite fails its
name-match assertion.

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

In `HashJoinExec::try_swapping_with_projection` and
`NestedLoopJoinExec::try_swapping_with_projection`, skip the
`try_pushdown_through_join` path for mark joins (`LeftMark`/`RightMark`)
and fall through to embedding the projection into the join instead.

## Are these changes tested?

Yes.

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

Yes, only bug fixes.

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

Author: lyne7-sc

datafusion/physical-plan/src/joins/hash_join/exec.rs

@@ -1520,20 +1520,23 @@ impl ExecutionPlan for HashJoinExec {
             return Ok(None);
         }
 
+        // TODO: split by `col`/`JoinSide` instead so mark joins can also push down to children.
         let schema = self.schema();
-        if let Some(JoinData {
-            projected_left_child,
-            projected_right_child,
-            join_filter,
-            join_on,
-        }) = try_pushdown_through_join(
-            projection,
-            self.left(),
-            self.right(),
-            self.on(),
-            &schema,
-            self.filter(),
-        )? {
+        if !matches!(self.join_type(), JoinType::LeftMark | JoinType::RightMark)
+            && let Some(JoinData {
+                projected_left_child,
+                projected_right_child,
+                join_filter,
+                join_on,
+            }) = try_pushdown_through_join(
+                projection,
+                self.left(),
+                self.right(),
+                self.on(),
+                &schema,
+                self.filter(),
+            )?
+        {
             self.builder()
                 .with_new_children(vec![
                     Arc::new(projected_left_child),

datafusion/physical-plan/src/joins/nested_loop_join.rs

@@ -734,20 +734,23 @@ impl ExecutionPlan for NestedLoopJoinExec {
             return Ok(None);
         }
 
+        // TODO: split by `col`/`JoinSide` instead so mark joins can also push down to children.
         let schema = self.schema();
-        if let Some(JoinData {
-            projected_left_child,
-            projected_right_child,
-            join_filter,
-            ..
-        }) = try_pushdown_through_join(
-            projection,
-            self.left(),
-            self.right(),
-            &[],
-            &schema,
-            self.filter(),
-        )? {
+        if !matches!(self.join_type(), JoinType::LeftMark | JoinType::RightMark)
+            && let Some(JoinData {
+                projected_left_child,
+                projected_right_child,
+                join_filter,
+                ..
+            }) = try_pushdown_through_join(
+                projection,
+                self.left(),
+                self.right(),
+                &[],
+                &schema,
+                self.filter(),
+            )?
+        {
             Ok(Some(Arc::new(NestedLoopJoinExec::try_new(
                 Arc::new(projected_left_child),
                 Arc::new(projected_right_child),

datafusion/sqllogictest/test_files/subquery.slt

@@ -1317,6 +1317,59 @@ physical_plan
 04)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
 05)------DataSourceExec: partitions=1, partition_sizes=[2]
 
+query TT
+explain select t1_id from t1
+where t1_id > 40 or exists (select 1 from t2 where t2.t2_int = t1.t1_int)
+----
+logical_plan
+01)Projection: t1.t1_id
+02)--Filter: t1.t1_id > Int32(40) OR __correlated_sq_1.mark
+03)----Projection: t1.t1_id, __correlated_sq_1.mark
+04)------LeftMark Join: t1.t1_int = __correlated_sq_1.t2_int
+05)--------TableScan: t1 projection=[t1_id, t1_int]
+06)--------SubqueryAlias: __correlated_sq_1
+07)----------TableScan: t2 projection=[t2_int]
+physical_plan
+01)FilterExec: t1_id@0 > 40 OR mark@1, projection=[t1_id@0]
+02)--HashJoinExec: mode=CollectLeft, join_type=RightMark, on=[(t2_int@0, t1_int@1)], projection=[t1_id@0, mark@2]
+03)----DataSourceExec: partitions=1, partition_sizes=[2]
+04)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
+05)------DataSourceExec: partitions=1, partition_sizes=[2]
+
+query I rowsort
+select t1_id from t1
+where t1_id > 40 or exists (select 1 from t2 where t2.t2_int = t1.t1_int)
+----
+11
+33
+44
+
+query TT
+explain select t1_id from t1
+where t1_id > 40 or not exists (select 1 from t2 where t2.t2_int > t1.t1_int)
+----
+logical_plan
+01)Projection: t1.t1_id
+02)--Filter: t1.t1_id > Int32(40) OR NOT __correlated_sq_1.mark
+03)----Projection: t1.t1_id, __correlated_sq_1.mark
+04)------LeftMark Join:  Filter: __correlated_sq_1.t2_int > t1.t1_int
+05)--------TableScan: t1 projection=[t1_id, t1_int]
+06)--------SubqueryAlias: __correlated_sq_1
+07)----------TableScan: t2 projection=[t2_int]
+physical_plan
+01)FilterExec: t1_id@0 > 40 OR NOT mark@1, projection=[t1_id@0]
+02)--NestedLoopJoinExec: join_type=RightMark, filter=t2_int@1 > t1_int@0, projection=[t1_id@0, mark@2]
+03)----DataSourceExec: partitions=1, partition_sizes=[2]
+04)----RepartitionExec: partitioning=RoundRobinBatch(4), input_partitions=1
+05)------DataSourceExec: partitions=1, partition_sizes=[2]
+
+query I rowsort
+select t1_id from t1
+where t1_id > 40 or not exists (select 1 from t2 where t2.t2_int > t1.t1_int)
+----
+33
+44
+
 statement ok
 set datafusion.explain.logical_plan_only = true;